667133 - Allow mail.SpellCheckBeforeSend to be tweaked by add-ons by converting it to an overridable function

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, enhancement)

Description

[Jonathan Kamens]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.6.17-1.fc14 Firefox/3.6.17 GTB7.1
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20110624 Thunderbird/7.0a1

In thread http://groups.google.com/group/mozilla.dev.apps.thunderbird/browse_thread/thread/83f98c2cab8bd58f/f104ea557a48d086 , I asked how I might be able to override mail.SpellCheckBeforeSend in my add-on without changing the preference temporarily, which is a no-no. David Bienvenu suggested perhaps adding a new function that checks the preference so that add-ons can override the function as needed. I ran that idea by Andrew Sutherland, and he liked it.

Attached, therefore, please find a patch which implements this proposed change.


Reproducible: Always

Comment 1

[Jonathan Kamens]

Attachment: patch to create and use new DoSpellCheckBeforeSend function

Comment 2

[David :Bienvenu]

Comment on attachment 541886 [details] [diff] [review]
patch to create and use new DoSpellCheckBeforeSend function

r=me for the Thunderbird part, but I shouldn't technically review the suite change.

Comment 3

[[e-mail]]

Comment on attachment 541886 [details] [diff] [review]
patch to create and use new DoSpellCheckBeforeSend function

>+  return sPrefs.getBoolPref("mail.SpellCheckBeforeSend");
We [SeaMonkey] are working on switching to Services.prefs so it would be handy if you could do this as you're touching the code already, thanks.

Comment 4

[Jonathan Kamens]

Attachment: Use Services.prefs instead of sPrefs for suite version of file

You mean like this?

Comment 5

[Jonathan Kamens]

Attachment: Patch just for the Thunderbird version of the file, just to make sure there's no confusion

Here's the same patch but this time just the Thunderbird part of it, since I submitted the Seamonkey part in a separate file. I know David already reviewed this, but just to avoid any confusion, I'm going to obsolete the patch he reviewed and submit this separate patch just for Thunderbird.

Comment 6

[Jim Porter (:squib)]

Checked in (suite): http://hg.mozilla.org/comm-central/rev/e88d35502646
Checked in (mail): http://hg.mozilla.org/comm-central/rev/f1a16d7594b8