667183 - Create a static nsGlobalWindow::Init method to do all one-shot initializations currently in nsGlobalWindow ctor

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 2

[Mounir Lamouri (:mounir)]

I realize some things, especially related to Preferences might not work as expected. I don't know for ::Add*VarCache but ::GetCString() might always return the default value because user pref will not be read yet.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 541925 [details] [diff] [review]
Patch v1

r=jst, but please do make sure that the preference values do get read correctly this early in startup (or that the value gets updated once the value is available).

Comment 4

[Boris Zbarsky [:bzbarsky]]

Once you land this, the null-check you added to the DOM memory reporter can get backed out, right?

Comment 5

[Mounir Lamouri (:mounir)]

(In reply to Boris Zbarsky (:bz) from comment #4)
> Once you land this, the null-check you added to the DOM memory reporter can
> get backed out, right?

If there is no weird situations where about:memory is loaded after ::Shutdown(), yes.

Comment 6

[Mounir Lamouri (:mounir)]

Attachment: Patch v1.1

With all preferences check staying in the ctor.

Comment 7

[Matt Brubeck (:mbrubeck)]

Backed out because of build failures on inbound.
https://hg.mozilla.org/integration/mozilla-inbound/rev/902d3de6f41d

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 557022 [details] [diff] [review]
Patch v1.1

>+  // There are two reasons to have Init() failing: if we were not able to
>+  // alloc the memory or if the size we want to init is too high. None of them
>+  // should happen.
>+  NS_ASSERTION(sWindowsById->Init(), "Init() should not fail!");

Are you seriously only calling Init in debug builds?

Comment 9

[Mounir Lamouri (:mounir)]

(In reply to Ms2ger from comment #8)
> Comment on attachment 557022 [details] [diff] [review]
> Patch v1.1
> 
> >+  // There are two reasons to have Init() failing: if we were not able to
> >+  // alloc the memory or if the size we want to init is too high. None of them
> >+  // should happen.
> >+  NS_ASSERTION(sWindowsById->Init(), "Init() should not fail!");
> 
> Are you seriously only calling Init in debug builds?

Oooouuuups :)
Fixed patch sent to try.

Comment 10

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/bc0b3ab327fa

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This broke DOMWINDOW printfs because you removed the --gRefCnt.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/releases/mozilla-release/rev/0432fe833c93
Create a static nsGlobalWindow::Init method to do one-shot initializations currently in nsGlobalWindow ctor. r=jst