The default bug view has changed. See this FAQ.

Enable JavaScript Shell packaging only when js executable is generated

RESOLVED FIXED in mozilla7

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Takanori MATSUURA, Assigned: Takanori MATSUURA)

Tracking

Trunk
mozilla7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
When firefox is built on top of xulrunner, no js executable is generated during building firefox. So we should generate jsshell zip package only when js executable is generated.

And NSPR libraries are not generated when --enable-system-nspr is set. So we should add NSPR libraries only when internal NSPR is built.
(Assignee)

Comment 1

6 years ago
Created attachment 542024 [details] [diff] [review]
Generate JavaScript Shell packag only when js executable is generated
Attachment #542024 - Flags: review?(ted.mielczarek)
Assignee: general → t.matsuu
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk
Comment on attachment 542024 [details] [diff] [review]
Generate JavaScript Shell packag only when js executable is generated

Review of attachment 542024 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. I thought there might be some situation where this would break, but I couldn't think of it while reviewing the original patch.
Attachment #542024 - Flags: review?(ted.mielczarek) → review+
Blocks: 543463
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Pushed to b-s:
http://hg.mozilla.org/projects/build-system/rev/bf88ac3f2316

Takanori, thanks for the patch! In the future, could you put the bug number in the changeset description? That way when someone pushes your patch for you they don't need to edit anything, they can just import it and push it.
Keywords: checkin-needed
Whiteboard: fixed-in-bs
(Assignee)

Comment 4

6 years ago
Ted,
Thank you for letting me know.
I'll carefully check the changeset description next time.
http://hg.mozilla.org/mozilla-central/rev/bf88ac3f2316
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Blocks: 668452
No longer blocks: 668452
You need to log in before you can comment on or make changes to this bug.