667474 - Do a basic computation of windows' size in the DOM Memory Reporter

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Basically, the idea of this patch is to add the code that goes trough all windows (even leaked ones) and add sizeof(*this) to the dom memory reporter section.
Documents/elements will be added in another bug same as improving window's memory usage computation.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 542173 [details] [diff] [review]
Patch v1

+  PRInt64 SizeOf() const {
+    return sizeof(*this);

Is there precedence in other similar code to use PRInt64 for the return type of SizeOf()? If not, I think we should use size_t here, or PRUint64 if size_t is no good.

r=jst with that.

Comment 3

[Nicholas Nethercote [inactive]]

PRInt64 is the return type for GetMemoryUsed() in nsIMemoryReporter classes, which is probably why Mounir is using it.

Comment 4

[Mounir Lamouri (:mounir)]

Exactly. I believe I should keep PRInt64 given that the only caller needs PRInt64 and not size_t. Though, Nicholas, why nsIMemoryReporter uses PRInt64 instead of size_t?

Comment 5

[Nicholas Nethercote [inactive]]

(In reply to comment #4)
> Though, Nicholas, why nsIMemoryReporter uses PRInt64 instead of size_t?

I don't know, it was like that when I inherited the code.

Comment 6

[Mounir Lamouri (:mounir)]

http://hg.mozilla.org/mozilla-central/rev/6539e8965444

Comment 7

[Mike Shaver (:shaver emeritus)]

(In reply to comment #5)
> (In reply to comment #4)
> > Though, Nicholas, why nsIMemoryReporter uses PRInt64 instead of size_t?
> 
> I don't know, it was like that when I inherited the code.

It was like that because it was designed to be called from script in the first about:memory impl vlad did.