Last Comment Bug 667485 - Add windows' document size to windows size
: Add windows' document size to windows size
Status: VERIFIED FIXED
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla7
Assigned To: Mounir Lamouri (:mounir)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on: 667474
Blocks: 663271 667497
  Show dependency treegraph
 
Reported: 2011-06-27 09:20 PDT by Mounir Lamouri (:mounir)
Modified: 2011-09-13 00:35 PDT (History)
1 user (show)
mounir: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (1.41 KB, patch)
2011-06-27 09:20 PDT, Mounir Lamouri (:mounir)
jst: review+
Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2011-06-27 09:20:53 PDT
Created attachment 542176 [details] [diff] [review]
Patch v1

... only for inner windows.
Comment 1 Johnny Stenback (:jst, jst@mozilla.com) 2011-06-27 17:14:55 PDT
Comment on attachment 542176 [details] [diff] [review]
Patch v1

s/PRInt64/size_t/ here as well.

r=jst
Comment 2 Mounir Lamouri (:mounir) 2011-06-29 08:43:50 PDT
http://hg.mozilla.org/mozilla-central/rev/27e8429814c3
Comment 3 Ioana (away) 2011-09-13 00:35:16 PDT
Fix visible in the /dom/base/nsGlobalWindow.h file:

    2.13 +    PRInt64 size = sizeof(*this);
    2.14 +
    2.15 +    if (IsInnerWindow() && mDoc) {
    2.16 +      size += mDoc->SizeOf();
    2.17 +    }
    2.18 +
    2.19 +    return size;

Note You need to log in before you can comment on or make changes to this bug.