667598 - memcached size bad resync

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Tarek Ziadé (:tarek)]

Syncing + restart memcached + add tab => quota exceeds.

That happens because the payload total size grabbed from sql is * by KB twice.

Comment 1

[Tarek Ziadé (:tarek)]

Attachment: don't *KB twice

test coming next

Comment 2

[Toby Elliott [:telliott]]

Comment on attachment 542258 [details] [diff] [review]
don't *KB twice

This is fine, but we shouldn't be trying to push it today

Comment 3

[Tarek Ziadé (:tarek)]

yes, agreed

Comment 4

[Tarek Ziadé (:tarek)]

Attachment: fix the KB issue + split the cache manager

Fixes the issue, and also splits the cache manager on its own module for clarity

Comment 5

[Tarek Ziadé (:tarek)]

Attachment: fix the KB issue + split the cache manager (v2)

Comment 6

[Toby Elliott [:telliott]]

2 things here:

1) I don't see the new Cachemanager as part of the diff

2) When we're scrambling to throw things onto a short-run train, I'm not sure that we should be making wholesale changes. I'd hold off checking this one in until after the push.

Comment 7

[Tarek Ziadé (:tarek)]

1) forgot to add the file, adding it

2) the cache manager is being moved to its own file for clarity, so there's no wholesale change here, beside the cleanups of the memcached <> db sync.

Comment 8

[Tarek Ziadé (:tarek)]

Attachment: fix the KB issue + split the cache manager (v3)

Comment 9

[Toby Elliott [:telliott]]

Comment on attachment 542505 [details] [diff] [review]
fix the KB issue + split the cache manager (v3)

This is ok, though it still seems a bad idea to be introducing new code at this time. _KB shouldn't be defined in a sql library (though we can leave it for now).

Comment 10

[Tarek Ziadé (:tarek)]

Yes KB could leave in services.util eventually. It's defined there because it's used only there, but there should be a couple of apps that can use it now

Comment 11

[Tarek Ziadé (:tarek)]

https://hg.mozilla.org/services/server-storage/rev/1eb1ca91de5a