dom should use mozilla::Preferences

RESOLVED FIXED in mozilla14

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Created attachment 542742 [details] [diff] [review]
Part.1 Add new APIs to mozilla::Preferences

dom needs nsIPrefServiceInsernal interface and GetType().
Attachment #542742 - Flags: review?(roc)
Created attachment 542743 [details] [diff] [review]
Part.2 dom should use mozilla::Preferences
Attachment #542743 - Flags: review?(jst)
Note that I don't change nsPluginsDirUnix.cpp.
http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsPluginsDirUnix.cpp#150

If I changed it, it would need more changes in the method because it's using the result buffer in low-level.
Comment on attachment 542742 [details] [diff] [review]
Part.1 Add new APIs to mozilla::Preferences

Review of attachment 542742 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #542742 - Flags: review?(roc) → review+
Comment on attachment 542743 [details] [diff] [review]
Part.2 dom should use mozilla::Preferences

Sigh, this *completely* fell through the cracks and got lost in my review queue, sorry! :(

r=jst, but this doesn't so much apply any more. I'll gladly review updated versions if needed (in no time this time, promise!)
Attachment #542743 - Flags: review?(jst) → review+
Created attachment 611773 [details] [diff] [review]
part.1 Add Preferences::GetType() and Preferences::GetDefaultType()
Attachment #542742 - Attachment is obsolete: true
Created attachment 611776 [details] [diff] [review]
part.2 mozilla/dom should use mozilla::Preferences

some pref names have been changed, I checked them again very carefully, but I'd like you to check them too.
Attachment #542743 - Attachment is obsolete: true
Attachment #611776 - Flags: review?(jst)
Comment on attachment 611776 [details] [diff] [review]
part.2 mozilla/dom should use mozilla::Preferences

Looks good, I checked all the pref names as well and didn't see anything wrong there.

r=jst!
Attachment #611776 - Flags: review?(jst) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0396f74d112b
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb3b3070ceff
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/0396f74d112b
https://hg.mozilla.org/mozilla-central/rev/cb3b3070ceff
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Depends on: 743785
You need to log in before you can comment on or make changes to this bug.