Closed Bug 668157 Opened 8 years ago Closed 8 years ago

dom should use mozilla::Preferences


(Core :: DOM: Core & HTML, defect)

Not set





(Reporter: masayuki, Assigned: masayuki)




(2 files, 2 obsolete files)

dom needs nsIPrefServiceInsernal interface and GetType().
Attachment #542742 - Flags: review?(roc)
Note that I don't change nsPluginsDirUnix.cpp.

If I changed it, it would need more changes in the method because it's using the result buffer in low-level.
Comment on attachment 542742 [details] [diff] [review]
Part.1 Add new APIs to mozilla::Preferences

Review of attachment 542742 [details] [diff] [review]:
Attachment #542742 - Flags: review?(roc) → review+
Comment on attachment 542743 [details] [diff] [review]
Part.2 dom should use mozilla::Preferences

Sigh, this *completely* fell through the cracks and got lost in my review queue, sorry! :(

r=jst, but this doesn't so much apply any more. I'll gladly review updated versions if needed (in no time this time, promise!)
Attachment #542743 - Flags: review?(jst) → review+
some pref names have been changed, I checked them again very carefully, but I'd like you to check them too.
Attachment #542743 - Attachment is obsolete: true
Attachment #611776 - Flags: review?(jst)
Comment on attachment 611776 [details] [diff] [review]
part.2 mozilla/dom should use mozilla::Preferences

Looks good, I checked all the pref names as well and didn't see anything wrong there.

Attachment #611776 - Flags: review?(jst) → review+
Depends on: 743785
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.