668157 - dom should use mozilla::Preferences

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Part.1 Add new APIs to mozilla::Preferences

dom needs nsIPrefServiceInsernal interface and GetType().

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Part.2 dom should use mozilla::Preferences

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Note that I don't change nsPluginsDirUnix.cpp.
http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsPluginsDirUnix.cpp#150

If I changed it, it would need more changes in the method because it's using the result buffer in low-level.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 542742 [details] [diff] [review]
Part.1 Add new APIs to mozilla::Preferences

Review of attachment 542742 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 542743 [details] [diff] [review]
Part.2 dom should use mozilla::Preferences

Sigh, this *completely* fell through the cracks and got lost in my review queue, sorry! :(

r=jst, but this doesn't so much apply any more. I'll gladly review updated versions if needed (in no time this time, promise!)

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.1 Add Preferences::GetType() and Preferences::GetDefaultType()

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.2 mozilla/dom should use mozilla::Preferences

some pref names have been changed, I checked them again very carefully, but I'd like you to check them too.

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 611776 [details] [diff] [review]
part.2 mozilla/dom should use mozilla::Preferences

Looks good, I checked all the pref names as well and didn't see anything wrong there.

r=jst!

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0396f74d112b
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb3b3070ceff

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/0396f74d112b
https://hg.mozilla.org/mozilla-central/rev/cb3b3070ceff