Improve screen reader reading of password manager intro text

RESOLVED FIXED in mozilla7

Status

()

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: MarcoZ, Assigned: MarcoZ)

Tracking

({access})

Trunk
mozilla7
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
Created attachment 542784 [details] [diff] [review]
Proposed less intrusive patch

Currently, the xul:description element is set to control the password tree, which on the screen reader side turns the text into the accDescription, which is additional info, not primary information.

In order for screen readers to better read the text,
a) the control attribute should be removed from xul:description, and an aria-labelledby attribute added to the xul:tree element.
or
b) the xul:description element should be turned into a xul:label element.

I'm attaching a patch for solution a). If reviewers think we should go with b) instead, which might introduce other differences which might not be desired on the visual side, I can attach a patch to that effect, too.
Attachment #542784 - Flags: review?
(Assignee)

Updated

7 years ago
Attachment #542784 - Flags: review? → review?(gavin.sharp)
(Assignee)

Comment 1

7 years ago
Created attachment 542786 [details] [diff] [review]
Alternative patch

This changes xul:description to xul:label. Note that I have no way of verifying visually whether this makes any difference for sighted users. This looks less intrusive, but is actually changing an element, but I'm proposing it anyway.
Attachment #542786 - Flags: review?(gavin.sharp)
Comment on attachment 542786 [details] [diff] [review]
Alternative patch

This change looks fine. It does not regress bug 482232.
Attachment #542786 - Flags: review?(gavin.sharp) → review+
Attachment #542784 - Flags: review?(gavin.sharp)
(Assignee)

Comment 3

7 years ago
Landed: http://hg.mozilla.org/mozilla-central/rev/5fcda42e70bd
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7

Updated

7 years ago
Assignee: nobody → marco.zehe
You need to log in before you can comment on or make changes to this bug.