668263 - Sometimes grossly inflated, sometimes no spacing in PDF output

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Stefan]

Attachment: Testcase to be printed as PDF

User Agent:  

Steps to reproduce:

1. Opened the testcase.
2. File-Print-Print to File-Output Format PDF-Print
3. Opened mozilla.pdf.
4. Repeated 1--3 several times.

[The Question "What DID you do?" cannot be answered using present tense. Is that intentional?]


Actual results:

Sometimes there was "grossly inflated spacing (wording stolen from Bug 667242, albeit  gfx.font_rendering.harfbuzz.scripts=3) and sometimes there was no spacing at all.


Expected results:

Letters in PDF should always have been spaced correctly.

Comment 1

[Stefan]

Attachment: Testcase PDF output showing grossly inflated spacing

Comment 2

[Stefan]

Version used to create PDF:
Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20110629 Firefox/7.0a1

Comment 3

[George Carstoiu]

 Mozilla/5.0 (X11; Linux i686; rv:8.0a1) Gecko/20110720 Firefox/8.0a1

Confirming issue - setting status to New.

Since when have you started seeing this problem?

Comment 4

[Stefan]

> Since when have you started seeing this problem?

On 2011-06-29 but I infrequently use the browser to print to PDF.

Comment 5

[Stefan]

Is this related to Bug 667242 - grossly inflated spacing in printed page when harfbuzz is disabled?

Comment 6

[Stefan]

(In reply to George Carstoiu from comment #3)
> Since when have you started seeing this problem?

2011-05-26-03-mozilla-central seems to be the first version which shows this problem.

Comment 7

[Stefan]

The problem occurs only with Type 1 fonts. The commit

http://hg.mozilla.org/mozilla-central/rev/db4b1f3096ea

seems to be the first which reproduces the problem.

Comment 8

[Stefan]

(In reply to Stefan from comment #7)
> http://hg.mozilla.org/mozilla-central/rev/db4b1f3096ea

I cannot trace back how I came to db4b1f3096ea so I did another bisection:

last good 2011-05-25-03-mozilla-central 836aa9658341
first bad 2011-05-26-03-mozilla-central 831f8e040f38

The first bad revision is:
changeset:   70170:acb4e51fa8a6
user:        Jeff Muizelaar <[e-mail]>
date:        Thu Mar 10 14:52:15 2011 -0500
summary:     Bug 562746. Update cairo to 1.10.

Comment 9

[Stefan]

With the two patches mentioned here

  https://bugs.freedesktop.org/show_bug.cgi?id=31062#c2

printing works fine again.

http://mail.gnome.org/archives/gnome-announce-list/2011-January/msg00005.html
--> https://bugs.freedesktop.org/show_bug.cgi?id=31062#2
    --> http://cgit.freedesktop.org/cairo/commit/?h=1.10&id=f47830dbbc34c7068ccdd8f7f9042e8734c9e408
    --> http://cgit.freedesktop.org/cairo/commit/?h=1.10&id=43c93f2b101f534f8aa4213403af3281fcdc17fb

Comment 10

[Stefan]

Attachment: patch

Comment 11

[Jonathan Kew [:jfkthame]]

Comment on attachment 586294 [details] [diff] [review]
patch

Jeff, it sounds like we should cherry-pick this from cairo.

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Is there anyway we can get an automated test for this?

Comment 13

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 586294 [details] [diff] [review]
patch

Adrian, what do you think of this?

Comment 14

[Jeff Muizelaar [:jrmuizel]]

/me realizes Adrian wrote those patches. Sorry for the noise.

Comment 15

[Jonathan Kew [:jfkthame]]

Pushed to -inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f43cfe78a5b4

Comment 16

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/f43cfe78a5b4