Closed Bug 668767 Opened 15 years ago Closed 14 years ago

Add-on guid for the pick of the month add-on should be added to the install link

Categories

(addons.mozilla.org Graveyard :: Discovery Pane, defect, P3)

Product:
addons.mozilla.org Graveyard
Component:
Discovery Pane
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: vladmaniac, Assigned: cvan)

References

Details

Henrik: It would be nice if the discovery pane would also list the add-on id in the ".install featureaddon" div element, which we could use to check that the real add-on has been installed.
Blocks: 657492
Other sections are having the guid of the add-on set as DOM attribute at the installation link, which is not the case for the pick of the month add-on.
Component: Add-ons Manager → Discovery Pane
OS: Linux → All
Product: Toolkit → addons.mozilla.org
QA Contact: add-ons.manager → discoverypane
Hardware: x86 → All
Summary: Discovery pane should list the add-on id in the ".install featureaddon" div element → Add-on id for the pick of the month add-on should be added to the install link
Assignee: nobody → bsavage
Priority: -- → P3
Target Milestone: --- → 6.1.5
Target Milestone: 6.1.5 → 6.1.6
Target Milestone: 6.1.6 → 6.1.7
We don't want to include that as the class, but as a DOM attribute. The discovery pane includes the addon id as a DOM data attribute: data-addon="6416" for example. I couldn't spot where we don't, could you possibly point to the URL where this is missing?
wontfix based on comment 2. The add-on id already exists in the dom
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WONTFIX
* data-addon="6416" this id works for AMO only, we need data-guid to work with discovery pane
As mentioned by Vlad we need the real add-on guid as given in the install.rdf and not the id from AMO. That's necessary to proof the correct source for our client-side Mozmill tests. Reopening.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Summary: Add-on id for the pick of the month add-on should be added to the install link → Add-on guid for the pick of the month add-on should be added to the install link
Assignee: bsavage → nobody
https://github.com/mozilla/zamboni/commit/9d61ebf I've added a `data-addonguid` attribute to the Monthly Pick panel (`li.panel`).
Assignee: nobody → cvan
Status: REOPENED → RESOLVED
Closed: 15 years ago → 14 years ago
Resolution: --- → FIXED
Target Milestone: 6.1.7 → 6.4.0
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.