668810 - Backport assertions module to old shared modules system

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The assertions module I have implemented on bug 634225 needs to be backported to our old shared module system to drastically enhance the way how assertions can be used. Shouldn't be too hard.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Backport was kinda easy, I only had to strip out the throw parts. Patch upcoming.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Geo, I have updated the one sessionstore test too to show-off the new feature! It works like a charm and we should use this module where-ever we can and should drop assert() completely.

Comment 4

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 543449 [details] [diff] [review]
Patch v1

r+, looks fine.

A little painful to have to do the import on assert, expect manually, but likely very worth the cost until we get the init stuff going. At least the frame code will be getting a lot of exercise :D

Comment 5

[u415141]

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/15283687

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #4)
> A little painful to have to do the import on assert, expect manually, but
> likely very worth the cost until we get the init stuff going. At least the
> frame code will be getting a lot of exercise :D

On the other side we would have to execute an init function in setupModule which would have the same costs. So there is no way around.

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/1c5e68da3df4 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/98a2b3a3f927 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/996847ca5b68 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/c7ce614d1ebf (release)

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Alex and Vlad, for each new test you are writing please use the new assertion methods supplied with those patches. We will come up with a documentation shortly which should make it easier for you.

Comment 8

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

FYI, https://developer.mozilla.org/en/Mozmill_Tests#Logging_Test_Results is the documentation