669728 - findCallerFrame should not call String.match on a filename (testUndoTabFromContextMenu.js)

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Module:    testUndoTabFromContextMenu.js
Test:      testUndoTabFromContextMenu    
Failure:   invalid quantifier 
Branches:  ALL
Platforms: ALL

With the landing of the assertions module in our current shared module system, we introduced an orange failure. Not sure how to reproduce so far but looks like something is wrong with calling the findCallerFrame method.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

A web search showed me that it is related to RegEx. I will dig into later.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, so this only fails if the repository gets cloned to a temporary location on OS X, e.g. "/var/folders/ur/urRSHOmhFJOHFVCrfZAVW++++TI/-Tmp-/tmpfgdil4.mozmill-tests".

Due to the contained special characters '+' and |-| it's not a valid regex and the call 'frame.filename.match(filename)' will fail. We should simply check if the filename is contained. No need to call match here.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

Comment 4

[u415141]

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/15762377

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 545874 [details] [diff] [review]
Patch v1

Looks good.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/01f08c17e829 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/d277bfbda5a8 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/94ffc9a64ffd (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/70b2dcbf7a5a (release)

I will come up with a follow-up for the API refactoring repo.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1 (api refactor)

Comment 8

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 545878 [details] [diff] [review]
Patch v1 (api refactor)

r+, looks fine. 

I agree this was the most appropriate fix. For times when we really do want to inject a string into a regex, I filed Bug 671705.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed on API refactoring repo:
https://github.com/geoelectric/mozmill-api-refactor/commit/57f7fe588d3e74413d86d28d6d8425b0394694ec