Closed Bug 669154 Opened 13 years ago Closed 13 years ago

Empty button briefly visible during startup from locale picker

Categories

(Firefox for Android Graveyard :: General, defect, P3)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect

Tracking

(firefox7 fixed, fennec7+)

Status:
VERIFIED FIXED
Milestone:
Firefox 8
Tracking Flags:
Tracking Status
firefox7 --- fixed
fennec 7+ ---

People

(Reporter: aaronmt, Assigned: wesj)

References

Details

(Keywords: regression, verified-aurora)

Attachments

(2 files)

Nightly (07/04) - Startup
17.27 KB, image/png
Details
Patch
3.48 KB, patch
mfinkle
: review+
mfinkle
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110704 Firefox/7.0a1 Fennec/7.0a1
Device: HTC Nexus One, Samsung Nexus S
OS: 2.3.4

Upon launching Nightly, I see an empty button from what looks like the locale picker.

STR: Create a new profile, launch Nightly

See screenshot
Gingerbread Only?
Priority: -- → P3
(In reply to comment #1)
> Gingerbread Only?

This issue occurs also on:
Build id : Mozilla/5.0 (Android;Linux armv7l;rv:8.0a1)Gecko/20110708
Firefox/8.0a1 Fennec/8.0a1
Device: LG Optimus 2x
OS: Android 2.2
Attached patch Patch — — Splinter Review 
This moves this check into the CLH so that we don't even show the window in this case. That also means (I think) we can remove some of this logic from localePicker.js
Assignee: nobody → wjohnston
Attachment #545403 - Flags: review?(mark.finkle)
Attachment #545403 - Flags: review?(mark.finkle) → review+
tracking-fennec: --- → 7+
status-firefox7: --- → affected
tracking-fennec: 7+ → ---
status-firefox7: affected → ---
Whiteboard: [inbound]
status-firefox7: --- → affected
tracking-firefox7: --- → ?
tracking-fennec: --- → 7+
tracking-firefox7: ? → ---
http://hg.mozilla.org/mozilla-central/rev/93ab40e65837
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 8
Mozilla/5.0 (Android; Linux armv71; rv8.0a1) Gecko/20110715 Firefox/8.0a1 Fennec/8.0a1
Device: HTC Flyer
OS: Android OS 2.3
Status: RESOLVED → VERIFIED
Comment on attachment 545403 [details] [diff] [review]
Patch

This should be pushed to aurora.
Attachment #545403 - Flags: approval-mozilla-aurora?
Comment on attachment 545403 [details] [diff] [review]
Patch

mobile-only and low-risk patch. been on nightly for a bit with no problems.
Attachment #545403 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified Fixed on Aurora (7.0a2)
Mozilla/5.0 (Android; Linux armv7l); rv:7.0a2) Gecko/20110725 Firefox/7.0a2 Fennec/7.0a2
Keywords: verified-aurora
Blocks: 689706
You need to log in before you can comment on or make changes to this bug.