669154 - Empty button briefly visible during startup from locale picker

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (07/04) - Startup

Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110704 Firefox/7.0a1 Fennec/7.0a1
Device: HTC Nexus One, Samsung Nexus S
OS: 2.3.4

Upon launching Nightly, I see an empty button from what looks like the locale picker.

STR: Create a new profile, launch Nightly

See screenshot

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Gingerbread Only?

Comment 2

[Cristian Nicolae (:xti)]

(In reply to comment #1)
> Gingerbread Only?

This issue occurs also on:
Build id : Mozilla/5.0 (Android;Linux armv7l;rv:8.0a1)Gecko/20110708
Firefox/8.0a1 Fennec/8.0a1
Device: LG Optimus 2x
OS: Android 2.2

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

This moves this check into the CLH so that we don't even show the window in this case. That also means (I think) we can remove some of this logic from localePicker.js

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/93ab40e65837

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Mozilla/5.0 (Android; Linux armv71; rv8.0a1) Gecko/20110715 Firefox/8.0a1 Fennec/8.0a1
Device: HTC Flyer
OS: Android OS 2.3

Comment 6

[Wesley Johnston (:wesj)]

Comment on attachment 545403 [details] [diff] [review]
Patch

This should be pushed to aurora.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 545403 [details] [diff] [review]
Patch

mobile-only and low-risk patch. been on nightly for a bit with no problems.

Comment 8

[Wesley Johnston (:wesj)]

Pushed to aurora: http://hg.mozilla.org/releases/mozilla-aurora/rev/df47e2abac6c

Comment 9

[Aaron Train [:aaronmt]]

Verified Fixed on Aurora (7.0a2)
Mozilla/5.0 (Android; Linux armv7l); rv:7.0a2) Gecko/20110725 Firefox/7.0a2 Fennec/7.0a2