669168 - last character of tab group name is sometimes lost

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[[e-mail] (:bhearsum)]

I haven't been able to isolate under what conditions this happens, but I find that the last character of the names of my tab groups disappears. It seems to happen singularly rather than in bulk, and I _think_ it only happens after I've edited a name (eg, upon creation). However, the loss doesn't appear instantly - I usually don't notice until I've gone into a tab group, and backed back out to the Tab Group UI.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Very strange, I just reproduced it. Will try to get an STR.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

STR:

1) Drag to create a new group
2) Enter its title
3) When entering the last letter keep the key pressed and click outside the group while the key is held down (those two actions must occur pretty quickly)
4) Restart Firefox and notice that the last letter wasn't saved

Explanation: We save the title on every mouseup-event (which is not fired for the last letter with the given STR).

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 544444 [details] [diff] [review]
patch v1

Review of attachment 544444 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/integration/fx-team/rev/515bdc18a91b

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/mozilla-central/rev/515bdc18a91b