Last Comment Bug 669168 - last character of tab group name is sometimes lost
: last character of tab group name is sometimes lost
Status: RESOLVED FIXED
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Panorama (show other bugs)
: unspecified
: All All
: -- normal
: Firefox 8
Assigned To: Tim Taubert [:ttaubert]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-04 07:23 PDT by Ben Hearsum (:bhearsum)
Modified: 2016-04-12 14:00 PDT (History)
1 user (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1 (660 bytes, patch)
2011-07-07 05:21 PDT, Tim Taubert [:ttaubert]
dietrich: review+
raymond: feedback+
Details | Diff | Splinter Review

Description Ben Hearsum (:bhearsum) 2011-07-04 07:23:53 PDT
I haven't been able to isolate under what conditions this happens, but I find that the last character of the names of my tab groups disappears. It seems to happen singularly rather than in bulk, and I _think_ it only happens after I've edited a name (eg, upon creation). However, the loss doesn't appear instantly - I usually don't notice until I've gone into a tab group, and backed back out to the Tab Group UI.
Comment 1 Tim Taubert [:ttaubert] 2011-07-07 03:10:04 PDT
Very strange, I just reproduced it. Will try to get an STR.
Comment 2 Tim Taubert [:ttaubert] 2011-07-07 05:09:45 PDT
STR:

1) Drag to create a new group
2) Enter its title
3) When entering the last letter keep the key pressed and click outside the group while the key is held down (those two actions must occur pretty quickly)
4) Restart Firefox and notice that the last letter wasn't saved

Explanation: We save the title on every mouseup-event (which is not fired for the last letter with the given STR).
Comment 3 Tim Taubert [:ttaubert] 2011-07-07 05:21:52 PDT
Created attachment 544444 [details] [diff] [review]
patch v1
Comment 4 Dietrich Ayala (:dietrich) 2011-07-08 08:22:06 PDT
Comment on attachment 544444 [details] [diff] [review]
patch v1

Review of attachment 544444 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 5 Tim Taubert [:ttaubert] 2011-07-11 10:56:14 PDT
http://hg.mozilla.org/integration/fx-team/rev/515bdc18a91b
Comment 6 Tim Taubert [:ttaubert] 2011-07-13 15:22:43 PDT
http://hg.mozilla.org/mozilla-central/rev/515bdc18a91b

Note You need to log in before you can comment on or make changes to this bug.