669242 - "Copies & Folders" account settings pane should assign ids to groupboxes so addons can add to them

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Jonathan Kamens]

Attachment: Patch to fix this issue.

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 20110615151330

Steps to reproduce:

Tried to add something from my add-on to the "Drafts, Archives, and Templates" groupbox on the "Copies & Folders" pane of the account settings.


Actual results:

I couldn't do it since the groupbox has no id.


Expected results:

The groupbox should have an id so that I can add to it in an overlay.

Comment 1

[Jonathan Kamens]

Hmm, on second thought, maybe it's on purpose that addons aren't allowed to do this, since it appears that the height of the window is fixed and when I try to add stuff to it, the stuff in the window gets cut off.

I wonder if that's a separate bug. Or maybe I should add a separate account settings page for my add-on?

Comment 2

[David :Bienvenu]

Cc'ing Blake for his opinion. Cc'ing rkent because I'm curious what he's done or would like to do in Exquilla.

Comment 3

[David :Bienvenu]

Comment on attachment 543849 [details] [diff] [review]
Patch to fix this issue.

I don't have a problem with adding the id's, in any case. It's probably possible for your extension to increase the size of the dialog as well (I'm not saying that's the right thing to do, but it's possible.) And I don't think the reason there are no group id's is to prevent you from tweaking the account settings.

Comment 4

[Mark Banner (:standard8)]

Jonathan: does this need landing?

Comment 5

[Jonathan Protzenko [:protz]]

Jonathan, I'd love it if you could use http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed in the future :-). Thanks for the good patch!

http://hg.mozilla.org/comm-central/rev/5d5e33532bc7