Closed Bug 669308 Opened 10 years ago Closed 10 years ago

Introduce Macros and method helpers to simplify participation of classes to the dom memory reporter

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
No description provided.
Attachment #543934 - Flags: review?(bzbarsky)
Attached patch Patch v1Splinter Review
Attachment #543935 - Flags: review?
Attachment #543934 - Attachment is obsolete: true
Attachment #543934 - Flags: review?(bzbarsky)
Attachment #543935 - Flags: review? → review?(bzbarsky)
Comment on attachment 543935 [details] [diff] [review]
Patch v1

>--- a/dom/base/nsDOMMemoryReporter.h
>+++ b/dom/base/nsDOMMemoryReporter.h
>+namespace mozilla {
>+  namespace dom {
>+    namespace MemoryReporter {
>+      /**

namespaces don't increase indentation, so

>+namespace mozilla {
>+namespace dom {
>+namespace MemoryReporter {
>+/**
Blocks: 669886
Comment on attachment 543935 [details] [diff] [review]
Patch v1

> It will compute the basic size of the object,
> +       * that means the size of the object without owned objects trough
> +       * pointers.  Owned object have to be added manually to ::SizeOf().

How about:

  It will compute the basic size of an object.  This means the size of the
  object itself plus everything owned by its superclasses.  This will not
  include the size of objects owned by this objects (which have to be manually
  added to ::SizeOf), but does include the size of any pointers to those
  objects stored in this object.

r= me
Attachment #543935 - Flags: review?(bzbarsky) → review+
Flags: in-testsuite-
Whiteboard: [inbound]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/414d5cd3a7e2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.