Introduce Macros and method helpers to simplify participation of classes to the dom memory reporter

RESOLVED FIXED in mozilla8

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla8
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 543934 [details] [diff] [review]
Patch v1
Attachment #543934 - Flags: review?(bzbarsky)
(Assignee)

Comment 1

6 years ago
Created attachment 543935 [details] [diff] [review]
Patch v1
Attachment #543935 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #543934 - Attachment is obsolete: true
Attachment #543934 - Flags: review?(bzbarsky)
(Assignee)

Updated

6 years ago
Attachment #543935 - Flags: review? → review?(bzbarsky)
Comment on attachment 543935 [details] [diff] [review]
Patch v1

>--- a/dom/base/nsDOMMemoryReporter.h
>+++ b/dom/base/nsDOMMemoryReporter.h
>+namespace mozilla {
>+  namespace dom {
>+    namespace MemoryReporter {
>+      /**

namespaces don't increase indentation, so

>+namespace mozilla {
>+namespace dom {
>+namespace MemoryReporter {
>+/**
(Assignee)

Updated

6 years ago
Blocks: 669886
Comment on attachment 543935 [details] [diff] [review]
Patch v1

> It will compute the basic size of the object,
> +       * that means the size of the object without owned objects trough
> +       * pointers.  Owned object have to be added manually to ::SizeOf().

How about:

  It will compute the basic size of an object.  This means the size of the
  object itself plus everything owned by its superclasses.  This will not
  include the size of objects owned by this objects (which have to be manually
  added to ::SizeOf), but does include the size of any pointers to those
  objects stored in this object.

r= me
Attachment #543935 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

6 years ago
Flags: in-testsuite-
Whiteboard: [inbound]
(Assignee)

Comment 4

6 years ago
Pushed:
http://hg.mozilla.org/mozilla-central/rev/414d5cd3a7e2
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.