Make nsMappedAttributeElement, nsStyledElement, nsStyledElementNotElementCSSInline, nsGenericHTMLElement, nsGenericHTMLFormElement and nsGenericHTMLFrameElement participate in DOM Memory Reporter

RESOLVED FIXED in mozilla8

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 544472 [details] [diff] [review]
Patch v1

I will probably have to make nsFrameLoader participate in DOM Memory Reporter too in another patch.
Attachment #544472 - Flags: review?(jst)

Updated

6 years ago
Attachment #544472 - Flags: review?(jst) → review+
Comment on attachment 544472 [details] [diff] [review]
Patch v1

>--- a/content/html/content/src/nsGenericHTMLElement.cpp
>+++ b/content/html/content/src/nsGenericHTMLElement.cpp
>+nsGenericHTMLFrameElement::SizeOf() const
>+{
>+  PRInt64 size = MemoryReporter::GetBasicSize<nsGenericHTMLFrameElement,
>+                                              nsGenericHTMLElement>(this);
>+  // TODO: might need to implement SizeOf() in nsFrameLoader.
>+  size += mFrameLoader ? sizeof(*mFrameLoader.get()) : 0;

Do you need the .get()?
(Assignee)

Updated

6 years ago
Whiteboard: [needs review] → [inbound]
this has been backed out by ehsan due to bustage with all the other changesets in the same push
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/c62d7cde4bf2
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.