Closed Bug 669886 Opened 12 years ago Closed 12 years ago

Make nsMappedAttributeElement, nsStyledElement, nsStyledElementNotElementCSSInline, nsGenericHTMLElement, nsGenericHTMLFormElement and nsGenericHTMLFrameElement participate in DOM Memory Reporter

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla8

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file)

Patch v1
7.13 KB, patch
jst
: review+
Details | Diff | Splinter Review
Attached patch Patch v1 — — Splinter Review 
I will probably have to make nsFrameLoader participate in DOM Memory Reporter too in another patch.
Attachment #544472 - Flags: review?(jst)
Attachment #544472 - Flags: review?(jst) → review+
Comment on attachment 544472 [details] [diff] [review]
Patch v1

>--- a/content/html/content/src/nsGenericHTMLElement.cpp
>+++ b/content/html/content/src/nsGenericHTMLElement.cpp
>+nsGenericHTMLFrameElement::SizeOf() const
>+{
>+  PRInt64 size = MemoryReporter::GetBasicSize<nsGenericHTMLFrameElement,
>+                                              nsGenericHTMLElement>(this);
>+  // TODO: might need to implement SizeOf() in nsFrameLoader.
>+  size += mFrameLoader ? sizeof(*mFrameLoader.get()) : 0;

Do you need the .get()?
Whiteboard: [needs review] → [inbound]
this has been backed out by ehsan due to bustage with all the other changesets in the same push
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/c62d7cde4bf2
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.