669564 - XMM6 and XMM7 aren't scratch register on Win64 ABI

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Makoto Kato [:m_kato]]

On Win64 ABI, scratch register for FP is xmm0-xmm5.  But Unix x86-64 ABI is xmm0-xmm7.   So Win64 sometime causes jit-tests failure.

So we don't include xmm6 and xmm7 as scratch registers on Win64.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Makoto Kato [:m_kato]]

After TI merge, math-jit-tests always become failure on Win64...

Comment 3

[Brian Hackett [Laid off!]]

Comment on attachment 544165 [details] [diff] [review]
fix

Review of attachment 544165 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 4

[Makoto Kato [:m_kato]]

http://hg.mozilla.org/tracemonkey/rev/d870a3d2a5ff

Comment 5

[Makoto Kato [:m_kato]]

Backed out by http://hg.mozilla.org/tracemonkey/rev/9863e9639d80

Comment 6

[Makoto Kato [:m_kato]]

It seems that XMM (FP) registers need continuity order...  I am investigating again.

Comment 7

[Makoto Kato [:m_kato]]

Attachment: fix (for m-c)

Comment 8

[Makoto Kato [:m_kato]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/2ebe327fac38

Also, I will handle same issue for TI repository if necessary.

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/2ebe327fac38