Closed Bug 669564 Opened 13 years ago Closed 13 years ago

XMM6 and XMM7 aren't scratch register on Win64 ABI

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86_64
Windows Vista
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla8

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file, 1 obsolete file)

fix (for m-c)
1.51 KB, patch
dvander
: review+
Details | Diff | Splinter Review 
On Win64 ABI, scratch register for FP is xmm0-xmm5.  But Unix x86-64 ABI is xmm0-xmm7.   So Win64 sometime causes jit-tests failure.

So we don't include xmm6 and xmm7 as scratch registers on Win64.
Summary: XMM6 and XMM7 isn't scratch register on Win64 ABI → XMM6 and XMM7 aren't scratch register on Win64 ABI
Blocks: 663748
Attached patch fix (obsolete) — — Splinter Review 

    
  

        Attachment #544165 -
        Flags: review?(bhackett1024)

    
    

    
  
After TI merge, math-jit-tests always become failure on Win64...

    
    

    
  
Comment on attachment 544165 [details] [diff] [review]
fix

Review of attachment 544165 [details] [diff] [review]:
-----------------------------------------------------------------

        Attachment #544165 -
        Flags: review?(bhackett1024) → review+

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/d870a3d2a5ff
Whiteboard: [fixed-in-tracemonkey]

    
    

    
  
Backed out by http://hg.mozilla.org/tracemonkey/rev/9863e9639d80
Whiteboard: [fixed-in-tracemonkey]

    
    

    
  
It seems that XMM (FP) registers need continuity order...  I am investigating again.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix (for m-c)
        — 
          — Splinter Review
      

    


  

        Attachment #544165 -
        Attachment is obsolete: true

    
  

        Attachment #547373 -
        Flags: review?(dvander)

        Attachment #547373 -
        Flags: review?(dvander) → review+

    
    

    
  
http://hg.mozilla.org/integration/mozilla-inbound/rev/2ebe327fac38

Also, I will handle same issue for TI repository if necessary.
Whiteboard: [inbound]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/2ebe327fac38
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: