XMM6 and XMM7 aren't scratch register on Win64 ABI

RESOLVED FIXED in mozilla8

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla8
x86_64
Windows Vista
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
On Win64 ABI, scratch register for FP is xmm0-xmm5.  But Unix x86-64 ABI is xmm0-xmm7.   So Win64 sometime causes jit-tests failure.

So we don't include xmm6 and xmm7 as scratch registers on Win64.
(Assignee)

Updated

6 years ago
Summary: XMM6 and XMM7 isn't scratch register on Win64 ABI → XMM6 and XMM7 aren't scratch register on Win64 ABI
(Assignee)

Updated

6 years ago
Blocks: 663748
(Assignee)

Comment 1

6 years ago
Created attachment 544165 [details] [diff] [review]
fix
(Assignee)

Updated

6 years ago
Attachment #544165 - Flags: review?(bhackett1024)
(Assignee)

Comment 2

6 years ago
After TI merge, math-jit-tests always become failure on Win64...
Comment on attachment 544165 [details] [diff] [review]
fix

Review of attachment 544165 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #544165 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/tracemonkey/rev/d870a3d2a5ff
Whiteboard: [fixed-in-tracemonkey]
(Assignee)

Comment 5

6 years ago
Backed out by http://hg.mozilla.org/tracemonkey/rev/9863e9639d80
Whiteboard: [fixed-in-tracemonkey]
(Assignee)

Comment 6

6 years ago
It seems that XMM (FP) registers need continuity order...  I am investigating again.
(Assignee)

Comment 7

6 years ago
Created attachment 547373 [details] [diff] [review]
fix (for m-c)
Attachment #544165 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #547373 - Flags: review?(dvander)
Attachment #547373 - Flags: review?(dvander) → review+
(Assignee)

Comment 8

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/2ebe327fac38

Also, I will handle same issue for TI repository if necessary.
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/2ebe327fac38
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.