Closed Bug 669582 Opened 13 years ago Closed 13 years ago

support using the VC++ compiler shipped with the Windows 7.1 SDK

Categories

(Firefox Build System :: MozillaBuild, task)

x86
Windows Server 2008
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

MozillaBuild currently detects the 7.1 SDK compiler as VC2010 Pro. It needs to detect this as VC2010 Express. It also needs to work around an apparently broken vcvars32 batch file (tries to look for non-existent files and keys).

While I was there, I added support for the 64-bit 7.x SDK compilers. I wrote it in such a way as to be as consistent between different batch files as possible, to make it easier to support future compilers.
Attached patch Proposed patchSplinter Review
Careful when applying this, the batch files have a mixture of line endings.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #544181 - Flags: review?(ted.mielczarek)
Comment on attachment 544181 [details] [diff] [review]
Proposed patch

Review of attachment 544181 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, but as usual with Mozillabuild, I cross my fingers and pray when changing these batch files.
Attachment #544181 - Flags: review?(ted.mielczarek) → review+
Pushed changeset 6eab83c2b4ed to mozilla-build.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
When will this be made available?
bug 631910 is tracking the next MozillaBuild release, which this will ship in.
No longer blocks: 754810
Blocks: 643807
Product: mozilla.org → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: