Closed
Bug 669582
Opened 13 years ago
Closed 13 years ago
support using the VC++ compiler shipped with the Windows 7.1 SDK
Categories
(Firefox Build System :: MozillaBuild, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file)
7.06 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
MozillaBuild currently detects the 7.1 SDK compiler as VC2010 Pro. It needs to detect this as VC2010 Express. It also needs to work around an apparently broken vcvars32 batch file (tries to look for non-existent files and keys). While I was there, I added support for the 64-bit 7.x SDK compilers. I wrote it in such a way as to be as consistent between different batch files as possible, to make it easier to support future compilers.
Assignee | ||
Comment 1•13 years ago
|
||
Careful when applying this, the batch files have a mixture of line endings.
Comment 2•13 years ago
|
||
Comment on attachment 544181 [details] [diff] [review] Proposed patch Review of attachment 544181 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine, but as usual with Mozillabuild, I cross my fingers and pray when changing these batch files.
Attachment #544181 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Pushed changeset 6eab83c2b4ed to mozilla-build.
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 4•13 years ago
|
||
When will this be made available?
Comment 5•13 years ago
|
||
bug 631910 is tracking the next MozillaBuild release, which this will ship in.
Updated•1 year ago
|
Product: mozilla.org → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•