669647 - need a unit test for undoing local message move/copy

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[David :Bienvenu]

I'm pretty sure undo doesn't work correctly with the maildir pluggable store, but the unit tests all pass, so I think we need xpcshell tests for this. We have tests for imap undo.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

This also adds firstMsgHdr to mailTestUtils.js because it's useful in a lot of tests.

In a follow-on fix, I'm going to fix some callers of loadFileToString to use loadMessageToString (some of them are loading a folder file to a string, which won't work with non-berkeley mail stores)

Comment 2

[David :Bienvenu]

Attachment: use LoadMessageToString in a few more places

Comment 3

[David :Bienvenu]

I should add redo to this, as well as undo/redo of multiple message move/copy, though I can leave that for a follow-on.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 544519 [details] [diff] [review]
use LoadMessageToString in a few more places

+  function undoDelete() {
+    gMsgWindow.transactionManager.undoTransaction();
+    // There's no listener for this, so we'll just have to wait a little.
+    do_timeout(1500, function(){doTest(++gCurTestNum);});
+  },

The alternative would if you could watch the folder for notification that the message had been added back to the folder. I don't mind if we do that in a follow-up improvement though.

Comment 5

[David :Bienvenu]

http://hg.mozilla.org/comm-central/rev/5e361c76f4e5