669762 - TabItem has incorrect close handler after unsuccessful TabItem.close() call

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

GroupItem.destroy() re-adds the following "close" event handler when a TabItem could not be closed:

>  child.addSubscriber(self, "close", function() {
>    self.remove(child);
>  });

https://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabview/groupitems.js#828

This is very different from the normal close handler:

>  item.addSubscriber(this, "close", function() {
>    let count = self._children.length;
>    let dontArrange = self.expanded || !self.shouldStack(count);
>    let dontClose = !item.closedManually && gBrowser._numPinnedTabs > 0;
>    self.remove(item, {dontArrange: dontArrange, dontClose: dontClose});
>
>    if (dontArrange)
>      self._freezeItemSize(count);
>
>    if (self._children.length > 0 && self._activeTab)
>      UI.setActive(self);
>  });

https://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabview/groupitems.js#1013

We should re-add the same close handler when a TabItem could not be closed.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 2

[Raymond Lee [:raymondlee]]

Comment on attachment 544364 [details] [diff] [review]
patch v1

Looks good

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 544364 [details] [diff] [review]
patch v1

Passed try:

http://tbpl.mozilla.org/?tree=Try&pusher=[e-mail]&rev=3efc59543378

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/integration/fx-team/rev/8c1f92fdd9fb

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/mozilla-central/rev/8c1f92fdd9fb