Closed Bug 670016 Opened 9 years ago Closed 9 years ago

automation.py unconditionally appends a -bin suffix to the appname

Categories

(Testing :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla9

People

(Reporter: jdm, Assigned: jruderman)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

In the case of fennec on OS X, this is incorrect and prevents running tests. Could we make it so that passing an explicit --appname argument avoids this problem?
Why don't we either:
a) Get rid of the -bin (Firefox doesn't need it anymore) or
b) Make things try without the -bin, and fall back to checking for it if the appname doesn't exist without it.
Attachment #552498 - Flags: review?(ted.mielczarek) → review-
I, too, ran into this bug trying to test Fennec on Mac.

I didn't implement exactly what Ted suggested in comment 2, because in apps that still live in the old world, we really do want the -bin version. (Running a shell script from automation.py is full of fail, IIRC.)

Once bug 552864 is ported to Thunderbird (and Seamonkey?), we can remove this hack entirely.
Attachment #558039 - Flags: review?(ted.mielczarek)
Blocks: 658850
Comment on attachment 558039 [details] [diff] [review]
Only append a -bin suffix if app-bin exists

Review of attachment 558039 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine.
Attachment #558039 - Flags: review?(ted.mielczarek) → review+
(In reply to Jesse Ruderman from comment #5)
> http://hg.mozilla.org/integration/mozilla-inbound/rev/2945d9f51362

landed on m-c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Component: Infrastructure → General
You need to log in before you can comment on or make changes to this bug.