Closed
Bug 670016
Opened 13 years ago
Closed 13 years ago
automation.py unconditionally appends a -bin suffix to the appname
Categories
(Testing :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla9
People
(Reporter: jdm, Assigned: jruderman)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
784 bytes,
patch
|
ted
:
review-
|
Details | Diff | Splinter Review |
1.09 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
In the case of fennec on OS X, this is incorrect and prevents running tests. Could we make it so that passing an explicit --appname argument avoids this problem?
Reporter | ||
Comment 1•13 years ago
|
||
Attachment #552498 -
Flags: review?(ted.mielczarek)
Comment 2•13 years ago
|
||
Why don't we either: a) Get rid of the -bin (Firefox doesn't need it anymore) or b) Make things try without the -bin, and fall back to checking for it if the appname doesn't exist without it.
Updated•13 years ago
|
Attachment #552498 -
Flags: review?(ted.mielczarek) → review-
Assignee | ||
Comment 3•13 years ago
|
||
I, too, ran into this bug trying to test Fennec on Mac. I didn't implement exactly what Ted suggested in comment 2, because in apps that still live in the old world, we really do want the -bin version. (Running a shell script from automation.py is full of fail, IIRC.) Once bug 552864 is ported to Thunderbird (and Seamonkey?), we can remove this hack entirely.
Attachment #558039 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•13 years ago
|
Blocks: domFuzzFennec
Comment 4•13 years ago
|
||
Comment on attachment 558039 [details] [diff] [review] Only append a -bin suffix if app-bin exists Review of attachment 558039 [details] [diff] [review]: ----------------------------------------------------------------- Seems fine.
Attachment #558039 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 5•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/2945d9f51362
Assignee: nobody → jruderman
Comment 6•13 years ago
|
||
(In reply to Jesse Ruderman from comment #5) > http://hg.mozilla.org/integration/mozilla-inbound/rev/2945d9f51362 landed on m-c
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Target Milestone: --- → mozilla9
Updated•11 years ago
|
Component: Infrastructure → General
You need to log in
before you can comment on or make changes to this bug.
Description
•