Closed Bug 670040 Opened 8 years ago Closed 8 years ago
ISession Startup .state a jsval to save repeatedly stringifying/parsing the initial state
No description provided.
Comment on attachment 544653 [details] [diff] [review] patch rev 1 yay jsvals!
Attachment #544653 - Flags: review?(paul) → review+
Landed: http://hg.mozilla.org/mozilla-central/rev/a65a4165c236 I updated https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsISessionStartup but this might want to go onto the Firefox 8 for developers page
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Since http://hg.mozilla.org/mozilla-central/rev/a65a4165c236 it has been impossible to compile under VS2010. I can't quite figure out why, but, a bisection shows this changeset as the culprit. The crash will usually occur once shlibsign.exe is hit. From my Event log: Faulting application name: shlibsign.exe, version: 0.0.0.0, time stamp: 0x4e216d7d Faulting module name: jemalloc.dll, version: 22.214.171.12414, time stamp: 0x4e21707a Exception code: 0xc0000005 Fault offset: 0x00004672 Faulting process id: 0x16d8 Faulting application start time: 0x01cc43aa429bab0f Faulting application path: d:\build\mozilla-central\obj-i686-pc-mingw32\nss\shlibsign.exe Faulting module path: d:\build\mozilla-central\obj-i686-pc-mingw32\dist\bin\jemalloc.dll Report Id: 810dca07-af9d-11e0-b7f0-001b2112456b
(In reply to comment #4) > Since http://hg.mozilla.org/mozilla-central/rev/a65a4165c236 it has been > impossible to compile under VS2010. I can't quite figure out why, but, a > bisection shows this changeset as the culprit. The crash will usually occur > once shlibsign.exe is hit. That'd be pretty surprising, none of the code changed is compiled by VS. Could you file a new bug so we can track it though.
That is fallout from Bug 671441.
Pushed http://hg.mozilla.org/integration/fx-team/rev/0ffeb8ce63f1 to update a comment so it says jsval instead of string
Mossop updated the docs here: https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsISessionStartup I added a note that the previous type was string. Also mentioned on Firefox 8 for developers.
You need to log in before you can comment on or make changes to this bug.