670040 - Make nsISessionStartup.state a jsval to save repeatedly stringifying/parsing the initial state

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Comment on attachment 544653 [details] [diff] [review]
patch rev 1

yay jsvals!

Comment 3

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/a65a4165c236

I updated https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsISessionStartup but this might want to go onto the Firefox 8 for developers page

Comment 4

[Mike Pesce (:By-Tor)]

Since http://hg.mozilla.org/mozilla-central/rev/a65a4165c236 it has been impossible to compile under VS2010.  I can't quite figure out why, but, a bisection shows this changeset as the culprit.  The crash will usually occur once shlibsign.exe is hit. 

From my Event log:
Faulting application name: shlibsign.exe, version: 0.0.0.0, time stamp: 0x4e216d7d
Faulting module name: jemalloc.dll, version: 8.0.0.4214, time stamp: 0x4e21707a
Exception code: 0xc0000005
Fault offset: 0x00004672
Faulting process id: 0x16d8
Faulting application start time: 0x01cc43aa429bab0f
Faulting application path: d:\build\mozilla-central\obj-i686-pc-mingw32\nss\shlibsign.exe
Faulting module path: d:\build\mozilla-central\obj-i686-pc-mingw32\dist\bin\jemalloc.dll
Report Id: 810dca07-af9d-11e0-b7f0-001b2112456b

Comment 5

[Dave Townsend [:mossop]]

(In reply to comment #4)
> Since http://hg.mozilla.org/mozilla-central/rev/a65a4165c236 it has been
> impossible to compile under VS2010.  I can't quite figure out why, but, a
> bisection shows this changeset as the culprit.  The crash will usually occur
> once shlibsign.exe is hit. 

That'd be pretty surprising, none of the code changed is compiled by VS. Could you file a new bug so we can track it though.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

That is fallout from Bug 671441.

Comment 7

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Pushed http://hg.mozilla.org/integration/fx-team/rev/0ffeb8ce63f1 to update a comment so it says jsval instead of string

Comment 8

[:Gavin Sharp [email: [e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/0ffeb8ce63f1

Comment 9

[Eric Shepherd [:sheppy]]

Mossop updated the docs here:

https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsISessionStartup

I added a note that the previous type was string.

Also mentioned on Firefox 8 for developers.