Get rid of NFSPWD from config.mk

RESOLVED FIXED in mozilla8

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sid0, Assigned: sid0)

Tracking

unspecified
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs [fixed-in-c-c])

Attachments

(2 attachments)

Bug 668053 comment 4:

> ::: config/config.mk
> @@ +683,2 @@
> >  else
> > +INSTALL_PWD     = `$(NFSPWD)`
> 
> Can you file a followup to get rid of NFSPWD? It looks like some ancient
> cruft that was probably only useful at Netscape or something.
(Assignee)

Comment 1

6 years ago
Created attachment 545615 [details] [diff] [review]
kill it (m-c)
Assignee: nobody → sid.bugzilla
Status: NEW → ASSIGNED
Attachment #545615 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 2

6 years ago
Created attachment 545616 [details] [diff] [review]
kill it (c-c)
Attachment #545616 - Flags: review?(bugspam.Callek)
Comment on attachment 545615 [details] [diff] [review]
kill it (m-c)

Review of attachment 545615 [details] [diff] [review]:
-----------------------------------------------------------------

(Ted is on vacation, so I'm taking this review)
Please also remove config/fastcwd.pl and js/src/config/fastcwd.pl. r=me with that.

I'd also suggest to do the same in nsprpub/
Attachment #545615 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

6 years ago
Isn't NSPR a separate repository that we import periodically?
(In reply to comment #4)
> Isn't NSPR a separate repository that we import periodically?

Yes.  You'd have to get an NSPR patch reviewed by ted or wtc.
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/projects/build-system/rev/7ded8e06e44e
Whiteboard: [fixed-in-bs]
(Assignee)

Comment 7

6 years ago
Pushed a bustage fix: https://hg.mozilla.org/projects/build-system/rev/981272eff3b7
(Assignee)

Comment 8

6 years ago
Comment on attachment 545616 [details] [diff] [review]
kill it (c-c)

Callek rs+'d this over IRC. Landed: https://hg.mozilla.org/comm-central/rev/38876eeaef86
Attachment #545616 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [fixed-in-bs] → [fixed-in-bs][fixed-in-c-c]
Whiteboard: [fixed-in-bs][fixed-in-c-c] → fixed-in-bs [fixed-in-c-c]
http://hg.mozilla.org/mozilla-central/rev/7ded8e06e44e
http://hg.mozilla.org/mozilla-central/rev/981272eff3b7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.