Closed
Bug 670249
Opened 14 years ago
Closed 14 years ago
Get rid of NFSPWD from config.mk
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla8
People
(Reporter: rain1, Assigned: rain1)
Details
(Whiteboard: fixed-in-bs [fixed-in-c-c])
Attachments
(2 files)
|
7.30 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
|
1.75 KB,
patch
|
rain1
:
review+
|
Details | Diff | Splinter Review |
Bug 668053 comment 4:
> ::: config/config.mk
> @@ +683,2 @@
> > else
> > +INSTALL_PWD = `$(NFSPWD)`
>
> Can you file a followup to get rid of NFSPWD? It looks like some ancient
> cruft that was probably only useful at Netscape or something.
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → sid.bugzilla
Status: NEW → ASSIGNED
Attachment #545615 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #545616 -
Flags: review?(bugspam.Callek)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 545615 [details] [diff] [review]
kill it (m-c)
Review of attachment 545615 [details] [diff] [review]:
-----------------------------------------------------------------
(Ted is on vacation, so I'm taking this review)
Please also remove config/fastcwd.pl and js/src/config/fastcwd.pl. r=me with that.
I'd also suggest to do the same in nsprpub/
Attachment #545615 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Isn't NSPR a separate repository that we import periodically?
(In reply to comment #4)
> Isn't NSPR a separate repository that we import periodically?
Yes. You'd have to get an NSPR patch reviewed by ted or wtc.
|
|
Assignee | |
Comment 6•14 years ago
|
||
Whiteboard: [fixed-in-bs]
|
|
Assignee | |
Comment 7•14 years ago
|
||
Pushed a bustage fix: https://hg.mozilla.org/projects/build-system/rev/981272eff3b7
|
|
Assignee | |
Comment 8•14 years ago
|
||
Comment on attachment 545616 [details] [diff] [review]
kill it (c-c)
Callek rs+'d this over IRC. Landed: https://hg.mozilla.org/comm-central/rev/38876eeaef86
Attachment #545616 -
Flags: review?(bugspam.Callek) → review+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [fixed-in-bs] → [fixed-in-bs][fixed-in-c-c]
|
||
Updated•14 years ago
|
Whiteboard: [fixed-in-bs][fixed-in-c-c] → fixed-in-bs [fixed-in-c-c]
http://hg.mozilla.org/mozilla-central/rev/7ded8e06e44e
http://hg.mozilla.org/mozilla-central/rev/981272eff3b7
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•