67067 - "unable to create directory" dialog is titleless

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Henrik Gemal]

the dialog "unable to create directory" doesn't have an title.

Comment 1

[Henrik Gemal]

To reproduce just try to install Mozilla into a directory called:
C:\Program Files\mozilla.org\Mozilla"""<<<<>>*

Comment 2

[Sean Su]

over to Ying.

Comment 3

[Ying-Lin Xia]

Bug fixed with the following patch, plus the file "install.ini" with an 
additional string:
   ERROR_MESSAGE_TITLE=Error

Comment 4

[Ying-Lin Xia]

Attachment: Patch

Comment 5

[Ying-Lin Xia]

Please r and sr. Thanks.

Comment 6

[tao]

Comment on attachment 59296 [details] [diff] [review]
Patch

Q: when is ERROR_MESSAGE_TITLE
defined? LXR didn't report any incidence of the string.

Comment 7

[Ying-Lin Xia]

Attachment: Patch for install.it

Comment 8

[Ying-Lin Xia]

Sean, can you please check the 2 patch in? I don't have the cvs account yet. 
Thanks.

Comment 9

[Ying-Lin Xia]

Since this bug is similar with bug 48051, I just made one patch for both bug 
fixes. Mark as "depends as".

dbragg: "Technically they're both "clean-up" type bugs and they're both in the 
same sub-system (the install wizard).  I believe that there would actually be 
less chance of error in a single check-in than if it was split into 2. I think 
would be the safest (and most efficient by the way) checkin procedure for these 
two bugs."

Comment 10

[Henrik Gemal]

we have an old old patch here?
Ying-Lin: is it still valid? And should we reassign to Sean?

Comment 11

[Sean Su]

it's a trivial patch.  I can drive it in once patches get sr=.

Comment 12

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 59296 [details] [diff] [review]
Patch

rs=dmose

Comment 13

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 59412 [details] [diff] [review]
Patch for install.it

sr=[e-mail], conditional on filing a new bug to use a string along the
lines of "$ProductInternalName$ Error" in the future so that it's possible to
tell what app this belongs to when looking at the Taskbar with Alt-TAB.

Comment 14

[Sean Su]

Attachment: patch v1.1

new patch that is merged against the current trunk (old patches got stale) and
also has dmose's suggested fix.

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 121473 [details] [diff] [review]
patch v1.1

a=asa (on behalf of drivers) for checkin to 1.4beta.

Comment 16

[Sean Su]

patch checked in.

Comment 17

[Sean Su]

patch backed out due to bug 203194.

Comment 18

[Sean Su]

patch checked in again.

Comment 19

[Grace Bush]

verified build 2003050104