671098 - Forces a nullpool when sqlite is used

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Tarek Ziadé (:tarek)]

This error :

ProgrammingError: (ProgrammingError) Cannot operate on a closed database. None [{}]

happens on concurrent accesses on sqlite.

we need to make sure storage *and* auth are using NullPool when sqlite is used.
in the default config, and raise a config error if it's the config tries to use pooling

Comment 1

[James Bonacci [:jbonacci]]

Verified in-house by Owen and myself...

Comment 2

[Tarek Ziadé (:tarek)]

Attachment: Make sure we use a NullPool when using SQLLite

Comment 3

[Rob Miller [:rmiller]]

Comment on attachment 548709 [details] [diff] [review]
Make sure we use a NullPool when using SQLLite

Review of attachment 548709 [details] [diff] [review]:
-----------------------------------------------------------------

sucks that you have to make some of these changes in 2 places, but other than that this looks fine.

Comment 4

[Tarek Ziadé (:tarek)]

yes that's because the user/ directory created to refactor things, duplicated the code found in /auth  -- this is one of the reasons I think we should have a another process when refactoring things so we don't dupe code.

Comment 5

[Tarek Ziadé (:tarek)]

done in http://hg.mozilla.org/services/server-core/rev/eabfa9a1744b

Comment 6

[Tarek Ziadé (:tarek)]

There's still one spot that needs this

Comment 7

[Tarek Ziadé (:tarek)]

Attachment: Forces NullPool when sqlite is used [storage]

Comment 8

[Tarek Ziadé (:tarek)]

http://hg.mozilla.org/services/server-core/rev/df16a6d6d04d

Comment 9

[Tarek Ziadé (:tarek)]

(In reply to comment #8)
> http://hg.mozilla.org/services/server-core/rev/df16a6d6d04d

wrong diff link. here you go: http://hg.mozilla.org/services/server-storage/rev/20804b8c945e