671196 - Kill content processes that cause processing errors in the chrome process

Status: RESOLVED FIXED

(Core :: IPC, defect, P1)

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Kill content processes that cause processing errors in the chrome process

Comment 2

[Benjamin Smedberg]

Mark the tracking flag when this lands: we'll want release drivers to watch the crash stats for Fennec to see if anything bad shows up.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

test_process_error.xul (which tests crashing the content process) is failing with this patch, because on windows the content process tries to set up D3D10 layers but they're not supported yet.  Something causes a protocol error, and then BAM the content process is killed.  It's good that this patch is working, but this reveals a fundamental problem: the kill-on-protocol-error approach isn't going to be able to trigger breakpad on windows.  Nor on Mac.  So we have to decide between killing a possibly-pwned process but getting crash reports from kills on plain-jane errors, or keeping things the way they are.  Will think on't.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Darnit, I forget we never landed this.

Comment 5

[Andreas Gal :gal]

Can this land?

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I've been sorting out test failures since Monday.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1cf20feadc1

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d1cf20feadc1