Last Comment Bug 671196 - Kill content processes that cause processing errors in the chrome process
: Kill content processes that cause processing errors in the chrome process
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: IPC (show other bugs)
: Trunk
: All All
: P1 normal (vote)
: mozilla17
Assigned To: Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
:
:
Mentors:
Depends on: 778067
Blocks: 746280 778025
  Show dependency treegraph
 
Reported: 2011-07-12 23:52 PDT by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2012-08-09 07:34 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
+


Attachments
Kill content processes that cause processing errors in the chrome process (1.88 KB, patch)
2011-07-12 23:54 PDT, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
benjamin: review+
Details | Diff | Splinter Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-07-12 23:52:37 PDT

    
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-07-12 23:54:51 PDT
Created attachment 545610 [details] [diff] [review]
Kill content processes that cause processing errors in the chrome process
Comment 2 Benjamin Smedberg [:bsmedberg] 2011-07-20 09:23:32 PDT
Mark the tracking flag when this lands: we'll want release drivers to watch the crash stats for Fennec to see if anything bad shows up.
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-07-21 22:50:14 PDT
test_process_error.xul (which tests crashing the content process) is failing with this patch, because on windows the content process tries to set up D3D10 layers but they're not supported yet.  Something causes a protocol error, and then BAM the content process is killed.  It's good that this patch is working, but this reveals a fundamental problem: the kill-on-protocol-error approach isn't going to be able to trigger breakpad on windows.  Nor on Mac.  So we have to decide between killing a possibly-pwned process but getting crash reports from kills on plain-jane errors, or keeping things the way they are.  Will think on't.
Comment 4 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-26 18:34:41 PDT
Darnit, I forget we never landed this.
Comment 5 Andreas Gal :gal 2012-08-08 09:23:09 PDT
Can this land?
Comment 6 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-08-08 10:52:57 PDT
I've been sorting out test failures since Monday.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1cf20feadc1
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-08-08 18:25:01 PDT
https://hg.mozilla.org/mozilla-central/rev/d1cf20feadc1

Note You need to log in before you can comment on or make changes to this bug.