Last Comment Bug 778067 - Re-enable layout/base/crashtests/735943.html when we can support crashed content processes better
: Re-enable layout/base/crashtests/735943.html when we can support crashed cont...
Status: RESOLVED WORKSFORME
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
:
Mentors:
Depends on:
Blocks: 671196
  Show dependency treegraph
 
Reported: 2012-07-27 01:46 PDT by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2016-03-12 12:28 PST (History)
2 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Disable 735943.html for <browser remote>, for now (1.92 KB, patch)
2012-07-27 02:09 PDT, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
justin.lebar+bug: review+
Details | Diff | Splinter Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-27 01:46:11 PDT
See the comment in the upcoming patch.  Attempting to "fix" this is not a good use of resources at the moment, and may lead to other bugs.

The behavior triggered by bug 671196 is good: the parent process gets into a state it can't handle and kills the child process.  The problem is, the reftest harness doesn't know how to restart crashed content processes.  We need that, but bug 671196 is more important right now IMHO.
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-27 02:09:05 PDT
Created attachment 646491 [details] [diff] [review]
Disable 735943.html for <browser remote>, for now

See comments in patch.  We should ensure that the mozbrowser window.open setup can handle this edge case.

This also raises the question of how to integrate <iframe mozbrowser> into the reftest harness, which you may want to participate in.  (Swapping it out for <browser remote> should be trivial.)
Comment 2 Justin Lebar (not reading bugmail) 2012-07-27 10:46:15 PDT
Comment on attachment 646491 [details] [diff] [review]
Disable 735943.html for <browser remote>, for now

sgtm
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-08-08 10:52:28 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b8130ed506c
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-08-08 18:25:08 PDT
https://hg.mozilla.org/mozilla-central/rev/1b8130ed506c
Comment 6 Ryan VanderMeulen [:RyanVM] 2016-03-12 12:28:09 PST
https://hg.mozilla.org/mozilla-central/rev/99611f9d56e1

Note You need to log in before you can comment on or make changes to this bug.