67128 - Need more Mac system colors for Classic theme

Status: VERIFIED WONTFIX

(Core :: CSS Parsing and Computation, defect)

Description

[Joe Hewitt (gone)]

I would really love to make the Mac classic theme use system colors instead of
hard-coded hex values like it does now.  In order to get there, we need to
support more of the native mac brush constants as css values.  In recent months
I've seen a bunch of checkins from blake and lord pixel which created a set of
-moz-mac colors, but we more than what we have so far.  One important color that
is missing is the depressed button color (kThemeBrushButtonFacePressed), which
is currently hard-coded as #666666.  

I'll be working on converting mac classic to use system colors in the next
couple days, and I'll list any other colors that are missing as I find them.

Comment 1

[Andrew Thompson]

Setting blocks to my bug on the skins *using* these colours.

Joe - I already made a list of many of these colours, but unfortunately I'm a
long way aways from the computer with it on. If you don't get done by the
weekend give me a shout and I'll send it to you.

Unfortunately you're going to discover some colours are simply unobtainable.
Also, to be honest I'd mostly concluded the way to go was to add all 40 Mac
colours to CSS for people to use as they please. Naturally we'd alias some of
them to more Moz friendly names.

In the long run this is only going to work for old style skins like Platinum.
Aqua need a different approach.

Comment 2

[Joe Hewitt (gone)]

After playing with Mac Classic for a while, I came to the sad conclusion that
it's not going to be possible to do 100% system color support on the Mac.  The
problem is mainly because of the way corners are drawn in the widgets.  They are
rounded and shaded in a way that can't be duplicated with css, even with
-moz-border-radius.  So we need to continue to use bitmaps for the corner
pieces, which means we're locked into using the Platinum color set.  I was
hoping that we could support Mac Themes, but it doesn't look good.

lordpixel, since you've already worked on this, and I probably won't have much
time to spend on this, I'll re-assign this bug to you.  Despite the problems I
just mentioned, it would be nice to get all these system colors in there anyway.

Comment 3

[Andrew Thompson]

Hmmm, OK, though I can't promise to do too much with it too soon. I mean, I have
a bunch of these fixes in my tree already but I really just need to spend a
couple of days coming up with some rational patches. Too damn busy with real
work though.

Hixie, Ben, Beard & myself are pretty much resigned that system colours are the
wrong way to go for just the reasons you describe. Hixie's trying to get them
removed (or at least not further extended) in CSS3. There are better ways to do
this:

(checkout mozilla/netwerk/protocol/theme - not part of the build)

but little time to work on them. I'm sure Aqua will provide some incentive...

Comment 4

[Daniel Wang]

this is a very old bug. this this bug still valid?

Comment 5

[Andrew Thompson]

Most of this is fairly irrelevant now, given that themes work in a very
different way. 

I doubt our system colors are entirely perfect, but it'd probably be more useful
to target specific problems as and when they occur.

Comment 6

[Daniel Wang]

v