57490 - Classic Skin: Need to use CSS2 system colours rather than hardcoded colours

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P3)

Description

[Andrew Thompson]

This depends on:

bug 1004 (I have a fix attached to this bug)

and

bug	46174	(I have a partial fix attached, working on it some more)

As I complete the patch to bug 46174 I will start to attach fixed Mac classic 
skin files here

Comment 1

[Andrew Thompson]

Also see bug: 57488 which deals with the fonts in the Mac classic skin

Comment 2

[Decklin Foster]

Here's another one with a patch: bug 56507

Comment 3

[Andrew Thompson]

Attachment: Fixes to classic/mac/TextField.css and Menu.css for theme compliance

Comment 4

[Andrew Thompson]

The first of (hopefully) many patches which build on the work I did getting 
system and appearnce manager colours working (bug 1004 and bug 46174). 

This patch gives Macs correct colours in contextual menus and text field focus 
rings. Reduces use of hardocoded colours in mac classic skin in favour of dynamic 
css colours which track the Appearance Manager.

Reviews please!

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

r=[e-mail]

Comment 6

[Blake Ross]

r=blake
I'll fix the spacing problems when I check it in.

Comment 7

[Blake Ross]

+	color                 : GrayText;
+	color                 : GreyText;

What is the reason for the variation here?

Comment 8

[Andrew Thompson]

Attachment: Fixed the GreyText GrayText thing

Comment 9

[Andrew Thompson]

the discrepancy is cause I'm British and we tend towards Grey over Gray. The 
official CSS spec is GrayText so I resolved it thay way.

BTW - I thought I wasn't supposed to have bugs assigned to me because I can't 
check in? Not that I mind.

Also, Blake, dunno if you saw my note but please leave this open when you check 
it in. There's lots more still to do to have a complete fix.

Comment 10

[Blake Ross]

That patch checked in.  It's fine to have bugs assigned to you even if you 
can't check in.

Comment 11

[andreww]

Could someone update the status of this bug? Is there something still 
pending to be checked in here?

Comment 12

[Andrew Thompson]

Weeesh! No, this was checked in a long time ago. 

Comment 13

[Andrew Thompson]

Should add: This bug was too general anyway. The patches in question are in.
Obviously we should hardcode less colours if possible, but then we also get into
the whole Aqua thing. If people have specific bugbears, please file specific
bugs on them.

Comment 14

[Andrew Thompson]

I just eyeballed the relevant files and all of the  significant changes are 
present, the patch is months old so its impossible to be 100% sure. I think if 
any colours where missed we'll just wait for ppl to file new bugs on those 
problems (if any).

IMO this can be verified.

Comment 15

[Patty Mac]

Verified on Mac OS 9.2 (branch build: 2001-10-12-03-0.9.4)