Closed Bug 57490 Opened 24 years ago Closed 23 years ago
Classic Skin: Need to use CSS2 system colours rather than hardcoded colours
Also see bug: 57488 which deals with the fonts in the Mac classic skin
Here's another one with a patch: bug 56507
The first of (hopefully) many patches which build on the work I did getting system and appearnce manager colours working (bug 1004 and bug 46174). This patch gives Macs correct colours in contextual menus and text field focus rings. Reduces use of hardocoded colours in mac classic skin in favour of dynamic css colours which track the Appearance Manager. Reviews please!
r=blake I'll fix the spacing problems when I check it in.
Assignee: hangas → lordpixel
+ color : GrayText; + color : GreyText; What is the reason for the variation here?
the discrepancy is cause I'm British and we tend towards Grey over Gray. The official CSS spec is GrayText so I resolved it thay way. BTW - I thought I wasn't supposed to have bugs assigned to me because I can't check in? Not that I mind. Also, Blake, dunno if you saw my note but please leave this open when you check it in. There's lots more still to do to have a complete fix.
Status: NEW → ASSIGNED
That patch checked in. It's fine to have bugs assigned to you even if you can't check in.
Could someone update the status of this bug? Is there something still pending to be checked in here?
Weeesh! No, this was checked in a long time ago.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Should add: This bug was too general anyway. The patches in question are in. Obviously we should hardcode less colours if possible, but then we also get into the whole Aqua thing. If people have specific bugbears, please file specific bugs on them.
I just eyeballed the relevant files and all of the significant changes are present, the patch is months old so its impossible to be 100% sure. I think if any colours where missed we'll just wait for ppl to file new bugs on those problems (if any). IMO this can be verified.
Verified on Mac OS 9.2 (branch build: 2001-10-12-03-0.9.4)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.