671555 - Preferences/Beta force add-ons compatibility option is not updated to the latest Beta build

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Extension Compatibility, defect)

Description

[Cristian Nicolae (:xti)]

Build id : Mozilla/5.0 (Android;Linux armv7l;rv:6.0)Gecko/20110713
Firefox/6.0 Fennec/6.0
Device: Motorola Droid 2
OS: Android 2.2

Steps to reproduce:
1. Open Fennec App
2. Go to Preferences > Beta tab
3. Enable force add-ons compatibility
4. Restart app
5. Go to about:config
6. Check if extensions.checkCompatibility preferences is updated for the running build

Expected result:
For Firefox 6 Beta 2, after step 6, about:config adds the following preference: extensions.checkCompatibility.6.0

Actual result:
After step 6, extensions.checkCompatibility.4.0b is added to about:config.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Feedback add-on is hard coded to use "extensions.checkCompatibility.4.0b" in it's preference UI. We need to dynamically generate the preference like it's done here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/browser/browser_globalwarnings.js#19

A simpler, safer fix could be used in fx6 (beta) branch, if we want to even take it now. I don't think we do.

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 551824 [details] [diff] [review]
patch

Nice

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee51239376b5

Comment 5

[Matt Brubeck (:mbrubeck)]

Comment on attachment 551824 [details] [diff] [review]
patch

Requesting mozilla-approval-aurora.  This patch is mobile-only, and the code it touches ships only in Nightly/Aurora/Beta builds (not release).  This is not a new regression (it first regressed in 5.0 beta), but it would be good to get this into our next beta migration.  Currently we are shipping an add-on to Beta users with a checkbox that fails to do anything.

Comment 6

[Johnathan Nightingale [:johnath]]

Comment on attachment 551824 [details] [diff] [review]
patch

Git er done before monday migration, please!

Comment 7

[Matt Brubeck (:mbrubeck)]

Landed on Aurora for Firefox 7:
https://hg.mozilla.org/releases/mozilla-aurora/rev/7894b27a5a9a

Comment 8

[Matt Brubeck (:mbrubeck)]

The previous push to inbound was missing part of the patch because of a manual rebase error.  Pushed it as a followup:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad7544a6078b

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/ee51239376b5

Comment 10

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/ad7544a6078b

Comment 11

[Andreea Pod]

Verified fixed on: Mozilla /5.0 (Android;Linux armv7l;rv:7.0) Gecko/20110816 Firefox/7.0 Fennec/7.0
Device: LG Optimus 2X