Last Comment Bug 671809 - Cmd+shift+F shortcut doesn't work while in Panorama
: Cmd+shift+F shortcut doesn't work while in Panorama
Status: RESOLVED FIXED
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Panorama (show other bugs)
: 6 Branch
: All All
: -- normal
: Firefox 8
Assigned To: Raymond Lee [:raymondlee]
:
Mentors:
Depends on: 587276 621795
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-15 01:25 PDT by Vlad [QA]
Modified: 2016-04-12 14:00 PDT (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
v1 (873 bytes, patch)
2011-07-20 04:22 PDT, Raymond Lee [:raymondlee]
ttaubert: review+
ttaubert: feedback+
Details | Diff | Review
Patch for checkin (1.11 KB, patch)
2011-07-24 09:06 PDT, Raymond Lee [:raymondlee]
no flags Details | Diff | Review

Description Vlad [QA] 2011-07-15 01:25:52 PDT
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:6.0) Gecko/20100101 Firefox/6.0 (beta1)

Cmd+shift+F shortcut doesn't work while in Panorama on MacOS X 10.7.

STR:
1. Start Firefox and hit Cmd+Shift+E to enter Panorama 
2. In Panorama, hit Cmd+Shift+F

Actual results:
Nothing happens. 

Expected results:
Firefox should enter full screen mode. If you go to Menu > View > Full Screen, it works fine.
Comment 1 Raymond Lee [:raymondlee] 2011-07-20 03:47:30 PDT
We only allow some of key events to work in Panorama.  Cmd+shift+F is not one of them.

I guess we should allow cmd+shift+F to work because user can go to full screen mode before entering Panorama.
Comment 2 Raymond Lee [:raymondlee] 2011-07-20 04:22:50 PDT
Created attachment 547029 [details] [diff] [review]
v1
Comment 3 Tim Taubert [:ttaubert] 2011-07-21 06:47:59 PDT
Comment on attachment 547029 [details] [diff] [review]
v1

Review of attachment 547029 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Comment 4 Ian Gilman [:iangilman] 2011-07-22 09:21:45 PDT
Comment on attachment 547029 [details] [diff] [review]
v1

Review of attachment 547029 [details] [diff] [review]:
-----------------------------------------------------------------

Now that Tim's a peer, he can do official reviews. :)
Comment 5 Tim Taubert [:ttaubert] 2011-07-23 07:02:18 PDT
Comment on attachment 547029 [details] [diff] [review]
v1

Review of attachment 547029 [details] [diff] [review]:
-----------------------------------------------------------------

Looks still good :)
Comment 6 Raymond Lee [:raymondlee] 2011-07-24 09:06:38 PDT
Created attachment 548015 [details] [diff] [review]
Patch for checkin

Passed try
http://tbpl.mozilla.org/?tree=Try&rev=32fb11e9137e
Comment 7 Tim Taubert [:ttaubert] 2011-07-27 22:24:05 PDT
http://hg.mozilla.org/integration/fx-team/rev/cb760f485af0
Comment 8 :Gavin Sharp [email: gavin@gavinsharp.com] 2011-07-28 10:01:03 PDT
http://hg.mozilla.org/mozilla-central/rev/cb760f485af0

Note You need to log in before you can comment on or make changes to this bug.