Closed Bug 671809 Opened 10 years ago Closed 10 years ago

Cmd+shift+F shortcut doesn't work while in Panorama

Categories

(Firefox Graveyard :: Panorama, defect)

6 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 8

People

(Reporter: vlad.ghetiu, Assigned: raymondlee)

References

Details

Attachments

(1 file, 1 obsolete file)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:6.0) Gecko/20100101 Firefox/6.0 (beta1)

Cmd+shift+F shortcut doesn't work while in Panorama on MacOS X 10.7.

STR:
1. Start Firefox and hit Cmd+Shift+E to enter Panorama 
2. In Panorama, hit Cmd+Shift+F

Actual results:
Nothing happens. 

Expected results:
Firefox should enter full screen mode. If you go to Menu > View > Full Screen, it works fine.
Depends on: 621795
We only allow some of key events to work in Panorama.  Cmd+shift+F is not one of them.

I guess we should allow cmd+shift+F to work because user can go to full screen mode before entering Panorama.
Assignee: nobody → raymond
OS: Mac OS X → All
Hardware: x86 → All
Summary: Cmd+shift+F shortcut doesn't work while in Panorama on MacOS X 10.7 → Cmd+shift+F shortcut doesn't work while in Panorama
Depends on: 587276
Attached patch v1 (obsolete) — Splinter Review
Attachment #547029 - Flags: feedback?(tim.taubert)
Comment on attachment 547029 [details] [diff] [review]
v1

Review of attachment 547029 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #547029 - Flags: feedback?(tim.taubert) → feedback+
Attachment #547029 - Flags: review?(ian)
Comment on attachment 547029 [details] [diff] [review]
v1

Review of attachment 547029 [details] [diff] [review]:
-----------------------------------------------------------------

Now that Tim's a peer, he can do official reviews. :)
Attachment #547029 - Flags: review?(ian) → review?(tim.taubert)
Comment on attachment 547029 [details] [diff] [review]
v1

Review of attachment 547029 [details] [diff] [review]:
-----------------------------------------------------------------

Looks still good :)
Attachment #547029 - Flags: review?(tim.taubert) → review+
Passed try
http://tbpl.mozilla.org/?tree=Try&rev=32fb11e9137e
Attachment #547029 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/cb760f485af0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.