6719 - Install.SetPackageFolder() needs to be implemented.

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Sean Su]

It currently simply returns NS_OK.

Comment 1

[Doug Turner (:dougt)]

From dveditz email:

This is defined in the documents on warp, the manual doesn't explain
this parameter (descriptions of the overloading is pretty poor).

For forms that don't take a folder object it will use the "package
folder" if one is set, otherwise it's an error.  The "package folder"
should be an internal variable of the nsInstall object (which probably
isn't there since SetPackageFolder() is not implemented).

If a package folder is set with SetPackageFolder() then it will be saved
in the registry, and can be used in these overloaded forms. If a default
package folder is found in the registry then it can be used in
overloaded forms without calling SetPackageFolder() -- but that would be
pretty ballsy to do in an install.

Instead, I would recommend something more like

   fpackage = Install.GetComponentFolder("mypackage");
   if ( fpackage == null ) {
        fpackage = askuserforfolder();
       Install.SetPackageFolder(fpackage);
   }

(Instead of asking the user you could simply GetFolder() some known
place where you want to do the install.)

In practice I suspect most installers simply stomp themselves into
specific directories and don't bother to check to see if a previous
version was installed somewhere else. Or if they check they do so via
the windows registry, which might be expected to stick around better
than info in the netscape registry.

Comment 2

[Jimmy Lee]

Changing QA Contact from Grace to Jimmy.  Ccing Paul.

Comment 3

[Cathleen]

added a task into the schedule, will figure out who can own this task.

Comment 4

[Cathleen]

set tfv to M9 for now.

Comment 5

[Sean Su]

I took the liberty to fix this since I fixed the related bug
http://bugzilla.mozilla.org/show_bug.cgi?id=6612

Look for the fix in the next build.

Comment 6

[Jimmy Lee]

Build 6/8/99
Behaves as expected.

Comment 7

[Sean Su]

*** Bug 6739 has been marked as a duplicate of this bug. ***

Comment 8

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine