The default bug view has changed. See this FAQ.

accessibility.browsewithcaret is sometimes enabled when it shouldn't be

VERIFIED FIXED in Firefox 7

Status

Fennec Graveyard
General
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

({regression, verified-aurora})

Trunk
Firefox 7
regression, verified-aurora
Dependency tree / graph

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 546601 [details] [diff] [review]
patch

I don't have reliable steps to reproduce this, but I find that caret browsing is sometimes enabled unexpectedly after I've been using Fennec for a while.  Looking at the code, this could happen if an error occurs in SelectionHelper.hide before the pref is unset.  This patch just adds a try block to hopefully catch these errors.
Attachment #546601 - Flags: review?(mark.finkle)
Comment on attachment 546601 [details] [diff] [review]
patch

I guess the popupState could be null or something
Attachment #546601 - Flags: review?(mark.finkle) → review+
Isn't this basically like bug 671052 (which was duplicated against bug 667243)?

Also, isn't it bad to add try..catch to work around a problem?
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/00df362906e9

(In reply to comment #2)
> Isn't this basically like bug 671052 (which was duplicated against bug
> 667243)?

Similar, though in my case the caret appeared after the handles were gone.

> Also, isn't it bad to add try..catch to work around a problem?

Yes, this is a slight hack because I could not reproduce the bug to be sure exactly where the error occurred.  This code will be removed when the real fix (bug 667243) is available.
Whiteboard: [inbound]
Ok, adding dependancy to bug 667243 then.
Depends on: 667243
http://hg.mozilla.org/mozilla-central/rev/00df362906e9
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
(Assignee)

Comment 6

6 years ago
Comment on attachment 546601 [details] [diff] [review]
patch

Requesting approval-mozilla-aurora.  This change is mobile-only and fixes a regression in Firefox 7.  The change is very low-risk; it just wraps a try/catch around an existing line of code.
Attachment #546601 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

6 years ago
status-firefox6: --- → unaffected
status-firefox8: affected → fixed

Updated

6 years ago
Attachment #546601 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 7

6 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/e0ad9f840fa6
status-firefox7: affected → fixed
Whiteboard: [inbound]
Target Milestone: Firefox 8 → Firefox 7
Verified Fixed

Nightly: Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110725 Firefox/8.0a1 Fennec/8.0a1
Aurora: Mozilla/5.0 (Android; Linux armv7l; rv:7.0a2) Gecko/20110725 Firefox/7.0a2 Fennec/7.0a2
Status: RESOLVED → VERIFIED
Keywords: verified-aurora
You need to log in before you can comment on or make changes to this bug.