672316 - accessibility.browsewithcaret is sometimes enabled when it shouldn't be

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

I don't have reliable steps to reproduce this, but I find that caret browsing is sometimes enabled unexpectedly after I've been using Fennec for a while.  Looking at the code, this could happen if an error occurs in SelectionHelper.hide before the pref is unset.  This patch just adds a try block to hopefully catch these errors.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 546601 [details] [diff] [review]
patch

I guess the popupState could be null or something

Comment 2

[Martijn Wargers (dead)]

Isn't this basically like bug 671052 (which was duplicated against bug 667243)?

Also, isn't it bad to add try..catch to work around a problem?

Comment 3

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/00df362906e9

(In reply to comment #2)
> Isn't this basically like bug 671052 (which was duplicated against bug
> 667243)?

Similar, though in my case the caret appeared after the handles were gone.

> Also, isn't it bad to add try..catch to work around a problem?

Yes, this is a slight hack because I could not reproduce the bug to be sure exactly where the error occurred.  This code will be removed when the real fix (bug 667243) is available.

Comment 4

[Martijn Wargers (dead)]

Ok, adding dependancy to bug 667243 then.

Comment 5

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/00df362906e9

Comment 6

[Matt Brubeck (:mbrubeck)]

Comment on attachment 546601 [details] [diff] [review]
patch

Requesting approval-mozilla-aurora.  This change is mobile-only and fixes a regression in Firefox 7.  The change is very low-risk; it just wraps a try/catch around an existing line of code.

Comment 7

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/e0ad9f840fa6

Comment 8

[Aaron Train [:aaronmt]]

Verified Fixed

Nightly: Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110725 Firefox/8.0a1 Fennec/8.0a1
Aurora: Mozilla/5.0 (Android; Linux armv7l; rv:7.0a2) Gecko/20110725 Firefox/7.0a2 Fennec/7.0a2