Created attachment 546601 [details] [diff] [review] patch I don't have reliable steps to reproduce this, but I find that caret browsing is sometimes enabled unexpectedly after I've been using Fennec for a while. Looking at the code, this could happen if an error occurs in SelectionHelper.hide before the pref is unset. This patch just adds a try block to hopefully catch these errors.
Comment on attachment 546601 [details] [diff] [review] patch I guess the popupState could be null or something
Isn't this basically like bug 671052 (which was duplicated against bug 667243)? Also, isn't it bad to add try..catch to work around a problem?
http://hg.mozilla.org/integration/mozilla-inbound/rev/00df362906e9 (In reply to comment #2) > Isn't this basically like bug 671052 (which was duplicated against bug > 667243)? Similar, though in my case the caret appeared after the handles were gone. > Also, isn't it bad to add try..catch to work around a problem? Yes, this is a slight hack because I could not reproduce the bug to be sure exactly where the error occurred. This code will be removed when the real fix (bug 667243) is available.
Comment on attachment 546601 [details] [diff] [review] patch Requesting approval-mozilla-aurora. This change is mobile-only and fixes a regression in Firefox 7. The change is very low-risk; it just wraps a try/catch around an existing line of code.
Verified Fixed Nightly: Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110725 Firefox/8.0a1 Fennec/8.0a1 Aurora: Mozilla/5.0 (Android; Linux armv7l; rv:7.0a2) Gecko/20110725 Firefox/7.0a2 Fennec/7.0a2