672574 - When GL Layers enabled, restarting Fennec causes black screen

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Ali Juma [:ajuma]]

As noted in the comments of bug 660072, when GL Layers are enabled on Android, pressing 'back' to return to the home screen and then pressing the Fennec icon again leads to a completely black window. 

There seem to be two issues here (when testing on a Nexus S):
1) After a restart, the first call to GLContext::RenewSurface() almost always fails, but the return value isn't currently checked. 
2) After a restart, a GeckoSurfaceView::surfaceChanged event occurs, but no drawing is initiated.

Comment 1

[Ali Juma [:ajuma]]

Attachment: Check return value of GLContext::RenewSurface(), and re-draw after the first GeckoSurfaceView::surfaceChanged following a restart

Comment 2

[Ali Juma [:ajuma]]

Comment on attachment 546837 [details] [diff] [review]
Check return value of GLContext::RenewSurface(), and re-draw after the first GeckoSurfaceView::surfaceChanged following a restart

I'm working on trying to better understand why GLContext::RenewSurface() is failing following a restart. 

The failures are coming from fMakeCurrent, which is producing an EGL_BAD_ALLOC error.

Discussing with BenWa, it seems we might need to explicitly destroy the GLContext when the activity pauses (and reconstruct on resume).

Comment 3

[Ali Juma [:ajuma]]

> I'm working on trying to better understand why GLContext::RenewSurface() is
> failing following a restart. 

This turned out to have the same underlying cause as Bug 677290 (we weren't releasing the GL surface when the Android surface was destroyed), so the patches for that bug also fixed this one.

Comment 4

[Ali Juma [:ajuma]]

(In reply to Ali Juma [:ajuma] from comment #3)
 
> This turned out to have the same underlying cause as Bug 677290 

That should be Bug 677920.