672642 - make queries static strings in storage

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Tarek Ziadé (:tarek)]

all in title

Comment 1

[Rob Miller [:rmiller]]

Attachment: change the static queries to use raw sql

Comment 2

[Tarek Ziadé (:tarek)]

Comment on attachment 547576 [details] [diff] [review]
change the static queries to use raw sql

My personal opinion is that if we're going to have static queries for clarity, I don't even see the benefit of keeping a dict.

Plain queries like:

QUERY = """\
select poof in doof
where toos = 1
"""

should be enough.

But that's just my opinion, I don't want to sound harsh here, so r+-ing

Comment 3

[Rob Miller [:rmiller]]

(In reply to comment #2)
> My personal opinion is that if we're going to have static queries for
> clarity, I don't even see the benefit of keeping a dict.
> 
> Plain queries like:
> 
> QUERY = """\
> select poof in doof
> where toos = 1
> """
>
> should be enough.

I didn't want to have to change any of the calling code (i.e. I wanted get_query() to continue to work exactly as before).  I could have put the queries at module scope and used globals() to look them up, but one query isn't created until get_query() is called, so I would have had to either stash that in the global dict (yuck) or done two lookups (not a big deal, really, but not the choice I took).

Comment 4

[Toby Elliott [:telliott]]

Comment on attachment 547576 [details] [diff] [review]
change the static queries to use raw sql

Patch appears to translate correctly. I've made a note in Bug 624542 that we should really bench that COLLECTION_MODIFIED query.

Comment 5

[Tarek Ziadé (:tarek)]

Applied by Rob at http://hg.mozilla.org/services/server-storage/rev/e04b8f36ebae