67270 - code cleanup and more performance for import mail

Status: RESOLVED WORKSFORME

(MailNews Core :: Profile Migration, defect)

Description

[Makoto Kato [:m_kato]]

code cleanup and more performance for import mail.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix at 2001/02/01

Comment 2

[Makoto Kato [:m_kato]]

Do you know who can review Import compomnent???

Comment 3

[(not reading, please use [e-mail] instead)]

tony would be the one to review this.

Comment 4

[tonyr]

looks good to me.

Comment 5

[(not reading, please use [e-mail] instead)]

makoto, don't do 

nsString uniqueName;

do 

nsAutoString uniqueName;

nsString and nsCString, as they allocate on the heap.  nsAutoString and
nsCAutoString are on the stack.

also,  instead of 

NS_ConvertASCIItoUCS2("foo").GetUnicode()

do

NS_LITERAL_STRING("foo").Get()

"Imported Mail" should be moved out into a string bundle, instead of hard coded.
feel free to take a crack at that here, or I can open a new bug.

Comment 6

[(not reading, please use [e-mail] instead)]

giving all my import bugs to chuang

Comment 7

[Matthias Versen [:Matti]]

*** Bug 107985 has been marked as a duplicate of this bug. ***

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

Any chance some of the ideas/code in this patch can be brought to life again?

Comment 9

[scottputterman]

reassigning to cavin.  marking nsbeta1-.

Comment 10

[Magnus Melin [:mkmelin]]

->WFM, unowned old bug with no usefulness anymore