Don't report per-compartment measurements that have zero bytes

RESOLVED FIXED in mozilla8

Status

()

Core
XPConnect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla8
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Here's an example compartment report:

   ├────3,940,269 B (01.07%) -- compartment(https://blog.mozilla.com/nnethercote/wp-login.php)
│  │    ├──2,736,128 B (00.74%) -- gc-heap
│  │    │  ├──1,330,152 B (00.36%) -- arena-unused
│  │    │  ├────781,760 B (00.21%) -- shapes
│  │    │  ├────557,888 B (00.15%) -- objects
│  │    │  ├─────34,616 B (00.01%) -- arena-padding
│  │    │  ├─────16,032 B (00.00%) -- arena-headers
│  │    │  ├─────15,680 B (00.00%) -- strings
│  │    │  └──────────0 B (00.00%) -- xml
│  │    ├────655,360 B (00.18%) -- mjit-code
│  │    ├────487,941 B (00.13%) -- scripts
│  │    ├─────47,344 B (00.01%) -- object-slots
│  │    ├─────13,496 B (00.00%) -- string-chars
│  │    ├──────────0 B (00.00%) -- mjit-data
│  │    ├──────────0 B (00.00%) -- tjit-code
│  │    └──────────0 B (00.00%) -- tjit-data
│  │               ├──0 B (00.00%) -- allocators-main
│  │               └──0 B (00.00%) -- allocators-reserve

Six entries are zero.  Printing them all is a bit pointless, especially since we can have lots of compartments.  I propose not reporting the zero entries to save space.

A side-benefit: it'll help us forget that E4X support exists :P
(Assignee)

Updated

6 years ago
Summary: Don't print sub-compartment entries that have zero bytes → Don't report per-compartment measurements that have zero bytes
(Assignee)

Comment 1

6 years ago
Created attachment 547323 [details] [diff] [review]
patch

Simple patch.
Attachment #547323 - Flags: review?(gal)

Updated

6 years ago
Attachment #547323 - Flags: review?(gal) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/e9b6850cc324
Whiteboard: [MemShrink] → [MemShrink][inbound]
http://hg.mozilla.org/mozilla-central/rev/e9b6850cc324
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [MemShrink][inbound] → [MemShrink]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.