Last Comment Bug 672796 - MOZILLA_GUARD_OBJECT_NOTIFIER_ONLY_PARAM and friends shouldn't be in AutoRestore.h
: MOZILLA_GUARD_OBJECT_NOTIFIER_ONLY_PARAM and friends shouldn't be in AutoRest...
Status: RESOLVED FIXED
[qa-]
:
Product: Core
Classification: Components
Component: MFBT (show other bugs)
: Trunk
: All All
: -- minor (vote)
: mozilla11
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on: 711818
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-20 07:27 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-12-18 01:20 PST (History)
3 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (17.08 KB, patch)
2011-10-31 04:26 PDT, :Ms2ger (⌚ UTC+1/+2)
khuey: review-
Details | Diff | Splinter Review
Patch v2 (17.45 KB, patch)
2011-10-31 10:41 PDT, :Ms2ger (⌚ UTC+1/+2)
khuey: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2011-07-20 07:27:07 PDT

    
Comment 1 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-07-20 08:35:35 PDT
Can we move these into mfbt now?
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-10-31 04:26:03 PDT
Created attachment 570646 [details] [diff] [review]
Patch v1
Comment 3 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-10-31 06:06:55 PDT
Comment on attachment 570646 [details] [diff] [review]
Patch v1

Review of attachment 570646 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/GuardObjects.h
@@ +40,5 @@
> +#ifndef mozilla_GuardObjects_h
> +#define mozilla_GuardObjects_h
> +
> +#include "mozilla/Types.h"
> +#include "nsDebug.h"

You can't include xpcom headers from mfbt.
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2011-10-31 10:41:31 PDT
Created attachment 570756 [details] [diff] [review]
Patch v2

K.
Comment 5 :Ms2ger (⌚ UTC+1/+2) 2011-11-16 10:30:34 PST
https://hg.mozilla.org/mozilla-central/rev/1193734e0207

with a Windows build fix the Green Intern suggested on IRC.

Note You need to log in before you can comment on or make changes to this bug.