Closed Bug 672796 Opened 8 years ago Closed 8 years ago

MOZILLA_GUARD_OBJECT_NOTIFIER_ONLY_PARAM and friends shouldn't be in AutoRestore.h

Categories

(Core :: MFBT, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch Patch v1 (obsolete) — Splinter Review
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #570646 - Flags: review?(khuey)
Comment on attachment 570646 [details] [diff] [review]
Patch v1

Review of attachment 570646 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/GuardObjects.h
@@ +40,5 @@
> +#ifndef mozilla_GuardObjects_h
> +#define mozilla_GuardObjects_h
> +
> +#include "mozilla/Types.h"
> +#include "nsDebug.h"

You can't include xpcom headers from mfbt.
Attachment #570646 - Flags: review?(khuey) → review-
Attached patch Patch v2Splinter Review
K.
Attachment #570646 - Attachment is obsolete: true
Attachment #570756 - Flags: review?(khuey)
https://hg.mozilla.org/mozilla-central/rev/1193734e0207

with a Windows build fix the Green Intern suggested on IRC.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → mozilla11
Component: XPCOM → MFBT
QA Contact: xpcom → mfbt
Depends on: 711818
You need to log in before you can comment on or make changes to this bug.