Note: There are a few cases of duplicates in user autocompletion which are being worked on.

MOZILLA_GUARD_OBJECT_NOTIFIER_ONLY_PARAM and friends shouldn't be in AutoRestore.h

RESOLVED FIXED in mozilla11

Status

()

Core
MFBT
--
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Can we move these into mfbt now?
(Assignee)

Comment 2

6 years ago
Created attachment 570646 [details] [diff] [review]
Patch v1
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #570646 - Flags: review?(khuey)
Comment on attachment 570646 [details] [diff] [review]
Patch v1

Review of attachment 570646 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/GuardObjects.h
@@ +40,5 @@
> +#ifndef mozilla_GuardObjects_h
> +#define mozilla_GuardObjects_h
> +
> +#include "mozilla/Types.h"
> +#include "nsDebug.h"

You can't include xpcom headers from mfbt.
Attachment #570646 - Flags: review?(khuey) → review-
(Assignee)

Comment 4

6 years ago
Created attachment 570756 [details] [diff] [review]
Patch v2

K.
Attachment #570646 - Attachment is obsolete: true
Attachment #570756 - Flags: review?(khuey)
Attachment #570756 - Flags: review?(khuey) → review+
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/1193734e0207

with a Windows build fix the Green Intern suggested on IRC.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → mozilla11
Component: XPCOM → MFBT
QA Contact: xpcom → mfbt
(Assignee)

Updated

6 years ago
Depends on: 711818
You need to log in before you can comment on or make changes to this bug.