672796 - MOZILLA_GUARD_OBJECT_NOTIFIER_ONLY_PARAM and friends shouldn't be in AutoRestore.h

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Can we move these into mfbt now?

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 570646 [details] [diff] [review]
Patch v1

Review of attachment 570646 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/GuardObjects.h
@@ +40,5 @@
> +#ifndef mozilla_GuardObjects_h
> +#define mozilla_GuardObjects_h
> +
> +#include "mozilla/Types.h"
> +#include "nsDebug.h"

You can't include xpcom headers from mfbt.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

K.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/1193734e0207

with a Windows build fix the Green Intern suggested on IRC.