Closed
Bug 711818
Opened 12 years ago
Closed 12 years ago
MOZILLA_GUARD_OBJECT_NOTIFIER* should use a MOZ_ prefix to follow MFBT style
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: Ms2ger, Assigned: mkohler)
References
Details
(Keywords: dev-doc-complete, Whiteboard: [good first bug][mentor=Ms2ger])
Attachments
(1 file)
18.31 KB,
patch
|
cjones
:
review+
Ms2ger
:
feedback+
|
Details | Diff | Splinter Review |
As suggested by Waldo: MFBT uses the MOZ_ prefix for its macros, so we should follow that rule for the macros in GuardObjects.h as well. Code: <http://mxr.mozilla.org/mozilla-central/source/mfbt/GuardObjects.h> Users: <http://mxr.mozilla.org/mozilla-central/search?string=MOZILLA_GUARD_OBJECT_NOTIFIER_&find=&findi=&filter=&hitlimit=&tree=mozilla-central> and <http://mxr.mozilla.org/mozilla-central/search?string=MOZILLA_GUARD_OBJECT_NOTIFIER_&find=&findi=&filter=&hitlimit=&tree=mozilla-central>
Reporter | ||
Comment 1•12 years ago
|
||
And of the two latter links should be <http://mxr.mozilla.org/mozilla-central/ident?i=MOZILLA_DECL_USE_GUARD_OBJECT_NOTIFIER>.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → michaelkohler
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #586737 -
Flags: review?
Assignee | ||
Updated•12 years ago
|
Attachment #586737 -
Flags: review? → review?(Ms2ger)
Assignee | ||
Updated•12 years ago
|
Attachment #586737 -
Flags: review?(Ms2ger) → review?(jones.chris.g)
Reporter | ||
Comment 3•12 years ago
|
||
Comment on attachment 586737 [details] [diff] [review] Patch v1 Looks good, thanks! Once cjones approves, we can land this.
Attachment #586737 -
Flags: feedback+
Updated•12 years ago
|
Attachment #586737 -
Flags: review?(jones.chris.g) → review+
Reporter | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/71eb0a8829cf Thanks for the patch!
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/71eb0a8829cf
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•12 years ago
|
||
Apparently mentioned on https://developer.mozilla.org/en/Using_RAII_classes_in_Mozilla
Keywords: dev-doc-needed
Comment 7•10 years ago
|
||
Fixed documentation: https://developer.mozilla.org/en-US/docs/Using_RAII_classes_in_Mozilla$compare?to=510637&from=510635
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•