711818 - MOZILLA_GUARD_OBJECT_NOTIFIER* should use a MOZ_ prefix to follow MFBT style

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

As suggested by Waldo: MFBT uses the MOZ_ prefix for its macros, so we should follow that rule for the macros in GuardObjects.h as well.

Code: <http://mxr.mozilla.org/mozilla-central/source/mfbt/GuardObjects.h>
Users: <http://mxr.mozilla.org/mozilla-central/search?string=MOZILLA_GUARD_OBJECT_NOTIFIER_&find=&findi=&filter=&hitlimit=&tree=mozilla-central> and <http://mxr.mozilla.org/mozilla-central/search?string=MOZILLA_GUARD_OBJECT_NOTIFIER_&find=&findi=&filter=&hitlimit=&tree=mozilla-central>

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

And of the two latter links should be <http://mxr.mozilla.org/mozilla-central/ident?i=MOZILLA_DECL_USE_GUARD_OBJECT_NOTIFIER>.

Comment 2

[Michael Kohler [:mkohler]]

Attachment: Patch v1

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 586737 [details] [diff] [review]
Patch v1

Looks good, thanks! Once cjones approves, we can land this.

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/71eb0a8829cf

Thanks for the patch!

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/71eb0a8829cf

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Apparently mentioned on https://developer.mozilla.org/en/Using_RAII_classes_in_Mozilla

Comment 7

[Daniel Holbert [:dholbert]]

Fixed documentation: https://developer.mozilla.org/en-US/docs/Using_RAII_classes_in_Mozilla$compare?to=510637&from=510635