MOZILLA_GUARD_OBJECT_NOTIFIER* should use a MOZ_ prefix to follow MFBT style

RESOLVED FIXED in mozilla12

Status

()

Core
MFBT
--
minor
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: Ms2ger, Assigned: mkohler)

Tracking

({dev-doc-complete})

Trunk
mozilla12
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=Ms2ger])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
As suggested by Waldo: MFBT uses the MOZ_ prefix for its macros, so we should follow that rule for the macros in GuardObjects.h as well.

Code: <http://mxr.mozilla.org/mozilla-central/source/mfbt/GuardObjects.h>
Users: <http://mxr.mozilla.org/mozilla-central/search?string=MOZILLA_GUARD_OBJECT_NOTIFIER_&find=&findi=&filter=&hitlimit=&tree=mozilla-central> and <http://mxr.mozilla.org/mozilla-central/search?string=MOZILLA_GUARD_OBJECT_NOTIFIER_&find=&findi=&filter=&hitlimit=&tree=mozilla-central>
(Reporter)

Comment 1

6 years ago
And of the two latter links should be <http://mxr.mozilla.org/mozilla-central/ident?i=MOZILLA_DECL_USE_GUARD_OBJECT_NOTIFIER>.
(Assignee)

Updated

6 years ago
Assignee: nobody → michaelkohler
(Assignee)

Comment 2

6 years ago
Created attachment 586737 [details] [diff] [review]
Patch v1
Attachment #586737 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #586737 - Flags: review? → review?(Ms2ger)
(Assignee)

Updated

6 years ago
Attachment #586737 - Flags: review?(Ms2ger) → review?(jones.chris.g)
(Reporter)

Comment 3

6 years ago
Comment on attachment 586737 [details] [diff] [review]
Patch v1

Looks good, thanks! Once cjones approves, we can land this.
Attachment #586737 - Flags: feedback+
Attachment #586737 - Flags: review?(jones.chris.g) → review+
(Reporter)

Updated

6 years ago
Keywords: checkin-needed

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/71eb0a8829cf

Thanks for the patch!
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/71eb0a8829cf
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

6 years ago
Apparently mentioned on https://developer.mozilla.org/en/Using_RAII_classes_in_Mozilla
Keywords: dev-doc-needed
Fixed documentation: https://developer.mozilla.org/en-US/docs/Using_RAII_classes_in_Mozilla$compare?to=510637&from=510635
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.