672814 - Increase the set of script @type values that nsScriptLoader treats as JavaScript

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The HTML5 draft has:

"application/ecmascript"
"application/javascript"
"application/x-ecmascript"
"application/x-javascript"
"text/ecmascript"
"text/javascript"
"text/javascript1.0"
"text/javascript1.1"
"text/javascript1.2"
"text/javascript1.3"
"text/javascript1.4"
"text/javascript1.5"
"text/jscript"
"text/livescript"
"text/x-ecmascript"
"text/x-javascript"

I don't know about all of these, but at least WebKit and Presto and Trident support text/jscript...  See http://stackoverflow.com/questions/6760193/javascript-jquery-works-in-every-browser-except-firefox

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://www.w3c-test.org/html/tests/submission/Ms2ger/the-elements-of-html/scripting/the-script-element/script-languages-02.html

Comment 2

[Boris Zbarsky [:bzbarsky]]

Note that I'm not convinced about everything in that list.  None of Gecko, WebKit, Presto support "text/javascript1.0" as far as I can tell.  Does Trident?

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

So text/javascript1.0 and friends are because of

> Otherwise, the element has a non-empty language attribute; let the script
> block's type for this script element be the concatenation of the string
> "text/" followed by the value of the language attribute.

I'm not convinced that's a good thing...

I'll have a look at supporting the others.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase for determining which script @type a browser supports

Comment 6

[Boris Zbarsky [:bzbarsky]]

So based on that testcase, browser engine support for the type values is like so ("IE" means all IE modes unless annotated otherwise:

"application/ecmascript": Gecko, Presto, WebKit, IE (in IE9 Standards document mode only)
"application/javascript": Gecko, Presto, WebKit, IE (in IE9 Standards document mode only)
"application/x-ecmascript": Presto
"application/x-javascript": Gecko, Presto, WebKit, IE (in IE9 Standards document mode only)
"text/ecmascript": All
"text/javascript": All
"text/javascript1.0": None
"text/javascript1.1": WebKit, IE
"text/javascript1.2": WebKit, IE
"text/javascript1.3": WebKit, IE
"text/javascript1.4": None
"text/javascript1.5": None
"text/jscript": Presto, WebKit, IE
"text/livescript": WebKit, IE
"text/x-ecmascript": Presto
"text/x-javascript": Presto, IE (in IE9 Standards document mode only)

Comment 7

[Boris Zbarsky [:bzbarsky]]

Ms2ger tells me that the IE10 results match IE9.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Yeah, we look at the language attribute separately.

Comment 9

[Odin Hørthe Omdal (odinho, Opera)]

Made a bug for Presto as well. I'll be following this bug and the WebKit one.

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: Move nsJSRuntime::ParseVersion to nsContentUtils

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Introduce nsContentUtils::IsJavascriptMIMEType

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part c: Remove the typeID variable in nsScriptLoader::ProcessScriptElement

Comment 13

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part c (diff -w)

Comment 14

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part d: Move the type attribute parsing into a helper function

Comment 15

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part e: Expand the set of JS mime types

Comment 16

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 644243 [details] [diff] [review]
Part a: Move nsJSRuntime::ParseVersion to nsContentUtils

Please rev the nsIScriptRuntime IID, and r=me.

Comment 17

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 644244 [details] [diff] [review]
Part b: Introduce nsContentUtils::IsJavascriptMIMEType

The comment about survey data doesn't seem all that relevant anymore.  r=me modulo that.

Comment 18

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 644245 [details] [diff] [review]
Part c: Remove the typeID variable in nsScriptLoader::ProcessScriptElement

r=me

Comment 19

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 644247 [details] [diff] [review]
Part d: Move the type attribute parsing into a helper function

r=me

Comment 20

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 644248 [details] [diff] [review]
Part e: Expand the set of JS mime types

r=me

Comment 21

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/39877da5d9dd
https://hg.mozilla.org/mozilla-central/rev/a246a4b88efb
https://hg.mozilla.org/mozilla-central/rev/ad10220d8093
https://hg.mozilla.org/mozilla-central/rev/7bdb887fadcf
https://hg.mozilla.org/mozilla-central/rev/8d520e1c2936

Comment 22

[Ed Morley [:emorley]]

Backed out with the mass tree revert to get rid of the OS X M5 orange:
https://hg.mozilla.org/mozilla-central/rev/c801b99d726f

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/48977890b1b8
https://hg.mozilla.org/integration/mozilla-inbound/rev/db7c6b522dcf
https://hg.mozilla.org/integration/mozilla-inbound/rev/72823d80a566
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b9b6c46393f
https://hg.mozilla.org/integration/mozilla-inbound/rev/7641d18552a6

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/48977890b1b8
https://hg.mozilla.org/mozilla-central/rev/db7c6b522dcf
https://hg.mozilla.org/mozilla-central/rev/72823d80a566
https://hg.mozilla.org/mozilla-central/rev/2b9b6c46393f
https://hg.mozilla.org/mozilla-central/rev/7641d18552a6