The default bug view has changed. See this FAQ.

Make pythonpath.py work better with pymake native commands

RESOLVED FIXED in mozilla8

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

unspecified
mozilla8
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

This means corralling the functionality into a 'main' method that we can call.
Created attachment 547244 [details] [diff] [review]
Patch
Attachment #547244 - Flags: review?(ted.mielczarek)
Blocks: 585015
Created attachment 547429 [details] [diff] [review]
Patch
Attachment #547244 - Attachment is obsolete: true
Attachment #547429 - Flags: review?(ted.mielczarek)
Attachment #547244 - Flags: review?(ted.mielczarek)
Comment on attachment 547429 [details] [diff] [review]
Patch

Review of attachment 547429 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/tests/test_expressionparser.txt
@@ +9,5 @@
>  
>  Test basic values::
>  
>      >>> parse("1")
> +    4

You're going to want to leave this out when you land this patch. :)

::: config/pythonpath.py
@@ +43,5 @@
> +
> +    execfile(script, frozenglobals)
> +
> +# Freeze scope here ... why this makes things work I have no idea ...
> +frozenglobals = globals()

This is a little goofy, but I'm sure there's a reasonable explanation. I would like to know what it is, but I'm not going to block you on landing this.
Attachment #547429 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/a751aa806dbf
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.