Last Comment Bug 672938 - Make pythonpath.py work better with pymake native commands
: Make pythonpath.py work better with pymake native commands
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: x86 Windows 7
: -- normal (vote)
: mozilla8
Assigned To: Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks: 585015
  Show dependency treegraph
 
Reported: 2011-07-20 13:50 PDT by Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
Modified: 2011-07-22 07:02 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (3.60 KB, patch)
2011-07-20 14:25 PDT, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
no flags Details | Diff | Splinter Review
Patch (4.12 KB, patch)
2011-07-21 10:07 PDT, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
ted: review+
Details | Diff | Splinter Review

Description Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-07-20 13:50:53 PDT
This means corralling the functionality into a 'main' method that we can call.
Comment 1 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-07-20 14:25:07 PDT
Created attachment 547244 [details] [diff] [review]
Patch
Comment 2 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-07-21 10:07:02 PDT
Created attachment 547429 [details] [diff] [review]
Patch
Comment 3 Ted Mielczarek [:ted.mielczarek] 2011-07-21 11:58:57 PDT
Comment on attachment 547429 [details] [diff] [review]
Patch

Review of attachment 547429 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/tests/test_expressionparser.txt
@@ +9,5 @@
>  
>  Test basic values::
>  
>      >>> parse("1")
> +    4

You're going to want to leave this out when you land this patch. :)

::: config/pythonpath.py
@@ +43,5 @@
> +
> +    execfile(script, frozenglobals)
> +
> +# Freeze scope here ... why this makes things work I have no idea ...
> +frozenglobals = globals()

This is a little goofy, but I'm sure there's a reasonable explanation. I would like to know what it is, but I'm not going to block you on landing this.
Comment 4 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-07-22 07:02:52 PDT
http://hg.mozilla.org/mozilla-central/rev/a751aa806dbf

Note You need to log in before you can comment on or make changes to this bug.