Last Comment Bug 585015 - Invoke header.py as a pymake native command
: Invoke header.py as a pymake native command
Status: RESOLVED FIXED
[pymake]
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla8
Assigned To: Kyle Huey [:khuey] (khuey@mozilla.com)
:
Mentors:
Depends on: 578478 672938 673003 673940
Blocks: 585010
  Show dependency treegraph
 
Reported: 2010-08-06 05:59 PDT by Ted Mielczarek [:ted.mielczarek]
Modified: 2011-07-25 09:04 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (2.97 KB, patch)
2011-07-21 12:26 PDT, Kyle Huey [:khuey] (khuey@mozilla.com)
mh+mozilla: review+
Details | Diff | Splinter Review

Description Ted Mielczarek [:ted.mielczarek] 2010-08-06 05:59:29 PDT
We should invoke header.py as a pymake native command to avoid the overhead of spawning a new Python interpreter every time we run it.
Comment 1 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-07-21 12:26:27 PDT
Created attachment 547468 [details] [diff] [review]
Patch
Comment 2 Mike Hommey [:glandium] 2011-07-21 14:36:48 PDT
Comment on attachment 547468 [details] [diff] [review]
Patch

Looking at the pymake tests, i see no space between % and module. I guess it doesn't matter if your patch works, but for consistency, you may want to remove that space.
Comment 3 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-07-22 07:03:24 PDT
http://hg.mozilla.org/mozilla-central/rev/a8d3614c62e2

Note You need to log in before you can comment on or make changes to this bug.