Closed
Bug 585015
Opened 15 years ago
Closed 14 years ago
Invoke header.py as a pymake native command
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla8
People
(Reporter: ted, Assigned: khuey)
References
Details
(Whiteboard: [pymake])
Attachments
(1 file)
|
2.97 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
We should invoke header.py as a pymake native command to avoid the overhead of spawning a new Python interpreter every time we run it.
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [pymake]
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → khuey
|
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #547468 -
Flags: review?(ted.mielczarek)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 547468 [details] [diff] [review]
Patch
Looking at the pymake tests, i see no space between % and module. I guess it doesn't matter if your patch works, but for consistency, you may want to remove that space.
Attachment #547468 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•