673022 - test_imapFilterActions leaks a lot of state

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[David :Bienvenu]

Attachment: proposed fix

test_imapFilterActions.js leaks a lot. The main problem was a listener that was not unregistered, but there was also some confusion about unregistering pending db listeners which I've fixed. (An exception was getting thrown, but the exception was because we were using Unregister... instead of unregister). I fixed that because I went to some trouble to make pending listeners do the right thing w.r.t. to dealing with active listeners and I don't want code out there that implies they don't.

Comment 1

[David :Bienvenu]

Attachment: couple more similar fixes

a couple more similar fixes. I don't see any remaining UnregisterPendingListener instances in the tree.

Comment 2

[Kent James (:rkent)]

Comment on attachment 547532 [details] [diff] [review]
couple more similar fixes

Although the patch seems correct and needed, it's funny that on check-interactive I do not see a leak on test_junkWhenDisabled, but when I run that with check-one I get:

nsStringStats
 => mAllocCount:           3740
 => mReallocCount:          593
 => mFreeCount:            3740
 => mShareCount:           8752
 => mAdoptCount:            298
 => mAdoptFreeCount:        298
<<<<<<<

== BloatView: ALL (cumulative) LEAK STATISTICS, default process 560

     |<----------------Class--------------->|<-----Bytes------>|<---------------
-Objects---------------->|<--------------References-------------->|
                                              Per-Inst   Leaked    Total      Re
m      Mean       StdDev     Total      Rem      Mean       StdDev
   0 TOTAL                                          27      184    13917
2 (  445.29 +/-   617.47)    36961        2 ( 1344.32 +/-  2151.78)
  60 morkObject                                     44       44      126
1 (   30.07 +/-    12.49)      459        1 (   47.89 +/-    17.65)
  64 morkTable                                     140      140       16
1 (    8.26 +/-     4.55)       38        1 (   18.05 +/-     9.55)

Comment 3

[David :Bienvenu]

check-interactive doesn't tell you about object leaks, and the morkTable leak is bug 673235

Comment 4

[David :Bienvenu]

http://hg.mozilla.org/comm-central/rev/92b97ca4be67