Closed
Bug 673164
Opened 14 years ago
Closed 14 years ago
Sync button in tab bar changes to Back button while syncing
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sdrocking, Assigned: soapy)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.79 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:8.0a1) Gecko/20110721 Firefox/8.0a1
Build ID: 20110721065410
Steps to reproduce:
With the default theme active and tabs on top, put the sync button in the tab bar. Now do a sync.
Actual results:
Sync button changes to back-button while syncing.
|
||
Comment 1•14 years ago
|
||
Which platform are you on? I can't reproduce this on OSX.
|
||
Updated•14 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Other → Windows 7
|
||
Comment 2•14 years ago
|
||
Confirmed on Windows 7.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110722 Firefox/8.0a1 ID:20110722030827
|
Reporter | |
Comment 3•14 years ago
|
||
Should this block Firefox 8?
|
Assignee | |
Comment 4•14 years ago
|
||
Temporary patch until an inverted sync throbber is made.
Attachment #550238 -
Flags: review?(dao)
|
|
||
Comment 5•14 years ago
|
||
Comment on attachment 550238 [details] [diff] [review]
Patch for 673164 v1
Doesn't http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser/browser.css#673 need to be updated as well?
|
|
Reporter | |
Comment 6•14 years ago
|
||
Please note that this issue doesn't happen with dark personas
|
|
Assignee | |
Comment 7•14 years ago
|
||
(In reply to comment #5)
> Comment on attachment 550238 [details] [diff] [review] [diff] [details] [review]
> Patch for 673164 v1
>
> Doesn't
> http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/
> browser/browser.css#673 need to be updated as well?
I don't think it is necessary because it is already specified on line 1117 http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser/browser.css#1117, but I can go ahead and make that change and upload another patch if you would like.
|
|
Assignee | |
Comment 8•14 years ago
|
||
Addressed comments by Dão.
Attachment #550238 -
Attachment is obsolete: true
Attachment #550238 -
Flags: review?(dao)
Attachment #550429 -
Flags: review?(dao)
|
|
||
Comment 9•14 years ago
|
||
Comment on attachment 550429 [details] [diff] [review]
Patch for 673164 v2
Looks good, thanks!
Attachment #550429 -
Flags: review?(dao) → review+
|
|
||
Comment 10•14 years ago
|
||
Assignee: nobody → soapyhamhocks
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•