Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Sync button in tab bar changes to Back button while syncing

RESOLVED FIXED

Status

()

Firefox
Theme
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sdrocking, Assigned: soapy)

Tracking

8 Branch
All
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:8.0a1) Gecko/20110721 Firefox/8.0a1
Build ID: 20110721065410

Steps to reproduce:

With the default theme active and tabs on top, put the sync button in the tab bar. Now do a sync.


Actual results:

Sync button changes to back-button while syncing.
(Reporter)

Updated

6 years ago
Blocks: 671553

Comment 1

6 years ago
Which platform are you on? I can't reproduce this on OSX.

Updated

6 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Other → Windows 7
Confirmed on Windows 7.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110722 Firefox/8.0a1 ID:20110722030827
(Reporter)

Comment 3

6 years ago
Should this block Firefox 8?
(Assignee)

Comment 4

6 years ago
Created attachment 550238 [details] [diff] [review]
Patch for 673164 	v1

Temporary patch until an inverted sync throbber is made.
Attachment #550238 - Flags: review?(dao)
Comment on attachment 550238 [details] [diff] [review]
Patch for 673164 	v1

Doesn't http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser/browser.css#673 need to be updated as well?
(Reporter)

Comment 6

6 years ago
Please note that this issue doesn't happen with dark personas
(Assignee)

Comment 7

6 years ago
(In reply to comment #5)
> Comment on attachment 550238 [details] [diff] [review] [diff] [details] [review]
> Patch for 673164 	v1
> 
> Doesn't
> http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/
> browser/browser.css#673 need to be updated as well?

I don't think it is necessary because it is already specified on line 1117 http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser/browser.css#1117, but I can go ahead and make that change and upload another patch if you would like.
(Assignee)

Comment 8

6 years ago
Created attachment 550429 [details] [diff] [review]
Patch for 673164 	v2

Addressed comments by Dão.
Attachment #550238 - Attachment is obsolete: true
Attachment #550238 - Flags: review?(dao)
Attachment #550429 - Flags: review?(dao)
Comment on attachment 550429 [details] [diff] [review]
Patch for 673164 	v2

Looks good, thanks!
Attachment #550429 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/b59ee1dfe623
Assignee: nobody → soapyhamhocks
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.