Closed Bug 673164 Opened 8 years ago Closed 8 years ago

Sync button in tab bar changes to Back button while syncing

Categories

(Firefox :: Theme, defect)

8 Branch
All
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: sdrocking, Assigned: soapy)

References

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:8.0a1) Gecko/20110721 Firefox/8.0a1
Build ID: 20110721065410

Steps to reproduce:

With the default theme active and tabs on top, put the sync button in the tab bar. Now do a sync.


Actual results:

Sync button changes to back-button while syncing.
Blocks: 671553
Which platform are you on? I can't reproduce this on OSX.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Other → Windows 7
Confirmed on Windows 7.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110722 Firefox/8.0a1 ID:20110722030827
Should this block Firefox 8?
Attached patch Patch for 673164 v1 (obsolete) — Splinter Review
Temporary patch until an inverted sync throbber is made.
Attachment #550238 - Flags: review?(dao)
Please note that this issue doesn't happen with dark personas
(In reply to comment #5)
> Comment on attachment 550238 [details] [diff] [review] [diff] [details] [review]
> Patch for 673164 	v1
> 
> Doesn't
> http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/
> browser/browser.css#673 need to be updated as well?

I don't think it is necessary because it is already specified on line 1117 http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser/browser.css#1117, but I can go ahead and make that change and upload another patch if you would like.
Addressed comments by Dão.
Attachment #550238 - Attachment is obsolete: true
Attachment #550238 - Flags: review?(dao)
Attachment #550429 - Flags: review?(dao)
Comment on attachment 550429 [details] [diff] [review]
Patch for 673164 	v2

Looks good, thanks!
Attachment #550429 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/b59ee1dfe623
Assignee: nobody → soapyhamhocks
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.