Remove the navigation toolbar's custom button appearance in small icons mode; invert icons on dark personas and glass

RESOLVED FIXED in Firefox 8

Status

()

Firefox
Theme
--
enhancement
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 8
All
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 545910 [details] [diff] [review]
patch
Attachment #545910 - Flags: ui-review?(shorlander)
(Assignee)

Comment 1

6 years ago
Created attachment 546204 [details] [diff] [review]
patch v2
Attachment #545910 - Attachment is obsolete: true
Attachment #546204 - Flags: review?(shorlander)
Attachment #545910 - Flags: ui-review?(shorlander)
(Assignee)

Updated

6 years ago
Blocks: 670565
(Assignee)

Comment 2

6 years ago
Created attachment 546273 [details] [diff] [review]
patch v3

another untested patch!
Attachment #546204 - Attachment is obsolete: true
Attachment #546273 - Flags: review?(shorlander)
Attachment #546204 - Flags: review?(shorlander)
(Assignee)

Comment 3

6 years ago
Created attachment 546274 [details] [diff] [review]
patch v3

typo eliminated
Attachment #546273 - Attachment is obsolete: true
Attachment #546274 - Flags: review?(shorlander)
Attachment #546273 - Flags: review?(shorlander)
(Assignee)

Updated

6 years ago
Blocks: 580194
(Assignee)

Comment 4

6 years ago
I'm back home and was finally able to test this. The latest patch appears to be working as expected.
Comment on attachment 546274 [details] [diff] [review]
patch v3

Review of attachment 546274 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Currently missing inverted icons for New Tab, Panorama and dropdown markers. Should we handle those in followup bugs?
Attachment #546274 - Flags: review?(shorlander) → review+
Created attachment 547385 [details]
Screenshot
(Assignee)

Comment 7

6 years ago
(In reply to comment #5)
> Currently missing inverted icons for New Tab, Panorama and
> dropdown markers. Should we handle those in followup bugs?

Yes. Bug 580194, I guess.
(Assignee)

Comment 8

6 years ago
http://hg.mozilla.org/mozilla-central/rev/ed75122f827c
http://hg.mozilla.org/mozilla-central/rev/6ffb760a41ca
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
(Assignee)

Updated

6 years ago
Blocks: 547440
Nice work! But I found an issue.
Put the sync button next to the tabs. Now do a sync.
The sync button changes to a back button. Please fix this.
Note: this happens only with the default theme.
(Assignee)

Comment 11

6 years ago
Please file a new bug.
Depends on: 673164
(In reply to comment #11)
> Please file a new bug.

Done, bug 673164

Comment 13

6 years ago
Thanks, Dão.  Looks good - much cleaner.
(Assignee)

Updated

6 years ago
Blocks: 673695

Comment 14

6 years ago
Created attachment 552949 [details]
Must be implemented on Tab Scroll Buttons too
(In reply to bogas04 from comment #14)
> Created attachment 552949 [details]
> Must be implemented on Tab Scroll Buttons too

The remaining work is being tracked in Bug 580194
(Assignee)

Updated

6 years ago
Duplicate of this bug: 586912

Comment 17

6 years ago
The new inverted icons are a good idea, but the removal of the button styles for the navigation toolbar was a very bad one.  This has caused grief for many users and skin writers.  See why at http://forums.mozillazine.org/viewtopic.php?f=38&t=2357753

This bug actually does two completely separate things and should have been split in two.

We now have a bug tracker to revert the navigation bar change introduced here: bug #700972
You need to log in before you can comment on or make changes to this bug.