Closed Bug 671553 Opened 8 years ago Closed 8 years ago
Remove the navigation toolbar's custom button appearance in small icons mode; invert icons on dark personas and glass
No description provided.
another untested patch!
I'm back home and was finally able to test this. The latest patch appears to be working as expected.
Comment on attachment 546274 [details] [diff] [review] patch v3 Review of attachment 546274 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! Currently missing inverted icons for New Tab, Panorama and dropdown markers. Should we handle those in followup bugs?
Attachment #546274 - Flags: review?(shorlander) → review+
(In reply to comment #5) > Currently missing inverted icons for New Tab, Panorama and > dropdown markers. Should we handle those in followup bugs? Yes. Bug 580194, I guess.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Nice work! But I found an issue. Put the sync button next to the tabs. Now do a sync. The sync button changes to a back button. Please fix this.
Note: this happens only with the default theme.
Please file a new bug.
Thanks, Dão. Looks good - much cleaner.
(In reply to bogas04 from comment #14) > Created attachment 552949 [details] > Must be implemented on Tab Scroll Buttons too The remaining work is being tracked in Bug 580194
The new inverted icons are a good idea, but the removal of the button styles for the navigation toolbar was a very bad one. This has caused grief for many users and skin writers. See why at http://forums.mozillazine.org/viewtopic.php?f=38&t=2357753 This bug actually does two completely separate things and should have been split in two. We now have a bug tracker to revert the navigation bar change introduced here: bug #700972
You need to log in before you can comment on or make changes to this bug.