Closed Bug 671553 Opened 8 years ago Closed 8 years ago

Remove the navigation toolbar's custom button appearance in small icons mode; invert icons on dark personas and glass

Categories

(Firefox :: Theme, enhancement)

All
Windows 7
enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 8

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(3 files, 3 obsolete files)

Attached patch patch (obsolete) — Splinter Review
No description provided.
Attachment #545910 - Flags: ui-review?(shorlander)
Attached patch patch v2 (obsolete) — Splinter Review
Attachment #545910 - Attachment is obsolete: true
Attachment #546204 - Flags: review?(shorlander)
Attachment #545910 - Flags: ui-review?(shorlander)
Blocks: 670565
Attached patch patch v3 (obsolete) — Splinter Review
another untested patch!
Attachment #546204 - Attachment is obsolete: true
Attachment #546273 - Flags: review?(shorlander)
Attachment #546204 - Flags: review?(shorlander)
Attached patch patch v3Splinter Review
typo eliminated
Attachment #546273 - Attachment is obsolete: true
Attachment #546274 - Flags: review?(shorlander)
Attachment #546273 - Flags: review?(shorlander)
Blocks: 580194
I'm back home and was finally able to test this. The latest patch appears to be working as expected.
Comment on attachment 546274 [details] [diff] [review]
patch v3

Review of attachment 546274 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Currently missing inverted icons for New Tab, Panorama and dropdown markers. Should we handle those in followup bugs?
Attachment #546274 - Flags: review?(shorlander) → review+
(In reply to comment #5)
> Currently missing inverted icons for New Tab, Panorama and
> dropdown markers. Should we handle those in followup bugs?

Yes. Bug 580194, I guess.
http://hg.mozilla.org/mozilla-central/rev/ed75122f827c
http://hg.mozilla.org/mozilla-central/rev/6ffb760a41ca
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Blocks: 547440
Nice work! But I found an issue.
Put the sync button next to the tabs. Now do a sync.
The sync button changes to a back button. Please fix this.
Note: this happens only with the default theme.
Please file a new bug.
Depends on: 673164
(In reply to comment #11)
> Please file a new bug.

Done, bug 673164
Thanks, Dão.  Looks good - much cleaner.
Blocks: 673695
(In reply to bogas04 from comment #14)
> Created attachment 552949 [details]
> Must be implemented on Tab Scroll Buttons too

The remaining work is being tracked in Bug 580194
Duplicate of this bug: 586912
The new inverted icons are a good idea, but the removal of the button styles for the navigation toolbar was a very bad one.  This has caused grief for many users and skin writers.  See why at http://forums.mozillazine.org/viewtopic.php?f=38&t=2357753

This bug actually does two completely separate things and should have been split in two.

We now have a bug tracker to revert the navigation bar change introduced here: bug #700972
You need to log in before you can comment on or make changes to this bug.