673440 - add support for NPNVSupportsCompositingCoreAnimationPluginsBool

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Josh Aas]

https://wiki.mozilla.org/NPAPI:QueryCoreAnimationCompositingSupport

Comment 1

[Benoit Girard (:BenWa)]

Attachment: patch v1

Comment 2

[Josh Aas]

Comment on attachment 547737 [details] [diff] [review]
patch v1

This looks good though the npapi.h changes should land as a sync with npapi-sdk. Lets open a bug on pulling that and land this after we've closed the new bug out.

The diff for nsNPAPIPlugin.cpp is funny - what are you changing about the impl for NPNVsupportsCoreAnimationBool and NPNVsupportsInvalidatingCoreAnimationBool?

Comment 3

[Benoit Girard (:BenWa)]

(In reply to comment #2)
> Comment on attachment 547737 [details] [diff] [review] [review]
> patch v1
> The diff for nsNPAPIPlugin.cpp is funny - what are you changing about the
> impl for NPNVsupportsCoreAnimationBool and
> NPNVsupportsInvalidatingCoreAnimationBool?

I had an extra whitespace, the code wasn't lining up. Housekeeping my intern code ^-^.

Comment 4

[Josh Aas]

This should be good to go, I updated the npapi headers.

Comment 5

[Dão Gottwald [:dao]]

patching file dom/plugins/base/npapi.h
Hunk #1 FAILED at 423

Comment 6

[Josh Aas]

The modifications to npapi.h in this patch can be thrown out. They are part of the npapi header update that already landed.

Comment 7

[Benoit Girard (:BenWa)]

Attachment: patch v2

Removed changed in dom/plugins/base/npapi.h landed in bug 674240, carrying forward r+.

Comment 8

[Benoit Girard (:BenWa)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1c136ef5cac2

Comment 9

[Marco Bonardo [:mak]]

I had to backout Bug 668953 and Bug 673440 from inbound because one of the two caused a Tp5 and Tp5 RSS regression on OSX 10.6.2. I don't know which of the two, if you have an idea you may reland the other one separately.

Comment 10

[Benoit Girard (:BenWa)]

Re-landing this change: 
http://hg.mozilla.org/integration/mozilla-inbound/rev/f53ac674db57

Unless a plugin is reading this value and misbehaving I don't see how it could cause a perf regression.

Comment 11

[Benoit Girard (:BenWa)]

Backout:
http://hg.mozilla.org/integration/mozilla-inbound/rev/9ab31534ef50

This was in fact the cause of the tp5 regression. There must be some plugins using this value already.

Comment 12

[Benoit Girard (:BenWa)]

Let's try this again once plugins are updated on talos.

Comment 13

[Benoit Girard (:BenWa)]

Attachment: patched, rebased. r=josh

I will push this if it doesn't regress try.

Comment 14

[Benoit Girard (:BenWa)]

https://tbpl.mozilla.org/?tree=Try&rev=0c0ee8bbade9

Comment 15

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f0d5bc7f55a

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6f0d5bc7f55a