Closed Bug 673440 Opened 8 years ago Closed 7 years ago
add support for NPNVSupports
Compositing Core Animation Plugins Bool
Comment on attachment 547737 [details] [diff] [review] patch v1 This looks good though the npapi.h changes should land as a sync with npapi-sdk. Lets open a bug on pulling that and land this after we've closed the new bug out. The diff for nsNPAPIPlugin.cpp is funny - what are you changing about the impl for NPNVsupportsCoreAnimationBool and NPNVsupportsInvalidatingCoreAnimationBool?
Attachment #547737 - Flags: review?(joshmoz) → review+
(In reply to comment #2) > Comment on attachment 547737 [details] [diff] [review] [review] > patch v1 > The diff for nsNPAPIPlugin.cpp is funny - what are you changing about the > impl for NPNVsupportsCoreAnimationBool and > NPNVsupportsInvalidatingCoreAnimationBool? I had an extra whitespace, the code wasn't lining up. Housekeeping my intern code ^-^.
This should be good to go, I updated the npapi headers.
patching file dom/plugins/base/npapi.h Hunk #1 FAILED at 423
The modifications to npapi.h in this patch can be thrown out. They are part of the npapi header update that already landed.
Removed changed in dom/plugins/base/npapi.h landed in bug 674240, carrying forward r+.
Attachment #547737 - Attachment is obsolete: true
I had to backout Bug 668953 and Bug 673440 from inbound because one of the two caused a Tp5 and Tp5 RSS regression on OSX 10.6.2. I don't know which of the two, if you have an idea you may reland the other one separately.
Re-landing this change: http://hg.mozilla.org/integration/mozilla-inbound/rev/f53ac674db57 Unless a plugin is reading this value and misbehaving I don't see how it could cause a perf regression.
Backout: http://hg.mozilla.org/integration/mozilla-inbound/rev/9ab31534ef50 This was in fact the cause of the tp5 regression. There must be some plugins using this value already.
Let's try this again once plugins are updated on talos.
Depends on: 664728
I will push this if it doesn't regress try.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.