update plugins used by talos

RESOLVED FIXED

Status

Testing
Talos
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: alice, Assigned: alice)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Assignee)

Description

7 years ago
Talos installs plugins into the default profile per-test run.  I don't believe that these have been updated in a long time.
(Assignee)

Updated

7 years ago
Assignee: nobody → anodelman
(Assignee)

Updated

7 years ago
Duplicate of this bug: 671288

Updated

7 years ago
Blocks: 663259

Updated

7 years ago
Blocks: 673440
(Assignee)

Comment 2

7 years ago
Pulling new copies of flash today, version 10.3.183.5.
\o/!
Thanks, this is important to fix the shutdown regression and may let us land bug 673440 without regressing.
(Assignee)

Comment 4

7 years ago
Don't get too excited just yet - still need to do some staging before this is ready to get deployed.
(Assignee)

Comment 5

7 years ago
So, during testing I'm finding some exceptions that will have to be handled:

- we'll want to run 64 bit flash on 64 bit browsers, this would be on our win7-64bit, fedora-64bit and most mac installs (for this I'll use Beta 2 11.0.d1.98, which is the current 64 bit flash release)
- we'll still need to install 32 bit flash correctly on xp, fed and the 1.9.2 branch
(Assignee)

Comment 6

7 years ago
Created attachment 557281 [details] [diff] [review]
[checked in] update names of flash zips in buildbot-configs
Attachment #557281 - Flags: review?(bear)

Updated

7 years ago
Attachment #557281 - Flags: review?(bear) → review+
(Assignee)

Comment 7

7 years ago
Created attachment 557282 [details] [diff] [review]
download 32/64 bit flash based upon os
Attachment #557282 - Flags: review?(bear)
(Assignee)

Comment 8

7 years ago
Patches green on staging.  New flash zips have already been posted to the build server by lsblakk.

Flash is installed and working.  Tested against nightly and 1.9.2 builds for confirmation.

Updated

7 years ago
Attachment #557282 - Flags: review?(bear) → review+
(Assignee)

Comment 9

7 years ago
Also, I've split out:

32 bit:
- use flash version 10.3.183.5
64 bit:
- use flash version 11.0.d1.98
> - we'll want to run 64 bit flash on 64 bit browsers, this would be on our
> win7-64bit, fedora-64bit and most mac installs (for this I'll use Beta 2
> 11.0.d1.98, which is the current 64 bit flash release)

I don't think we want to use 64 bit flash release on mac. Our default configuration, used by our users, is to use the 64 bit browser and run 32 bit plugins using a compatibility layer. I believe this is only the case on Mac. Flash 64-bit is still beta software so I think we rather test our default configuration.
(Assignee)

Updated

7 years ago
Depends on: 683687
(Assignee)

Comment 11

7 years ago
So, that would mean only 64 bit on fed64 and win764.  I'll try and get some new zips and patch changes pulled together.
(Assignee)

Comment 12

7 years ago
Created attachment 557301 [details] [diff] [review]
[checked in] download 64 bit flash for win764/fed64 only
Attachment #557282 - Attachment is obsolete: true
Attachment #557301 - Flags: review?(bear)

Updated

7 years ago
Attachment #557301 - Flags: review?(bear) → review+
(Assignee)

Comment 13

7 years ago
Copies of flash zips have been updated on the build server by lsblakk.  32 bit flash zip now contains 10.3.183.5 for mac.

The new split is:

32 bit (fed, winxp, win7, leopard, snow leopard):
- use flash version 10.3.183.5
64 bit (fed64, win7 64):
- use flash version 11.0.d1.98
(Assignee)

Comment 14

7 years ago
This is now waiting on deployment, which must happen during a downtime as it will affect all tp4/tp5 results.

I've not checked in the patches as I don't want them to get accidentally picked up during a non-downtime reconfig.
Do we have any measurement of the impact this will have for Talos? I'm expecting this upgrade to fix the tp5 shutdown regression. Or do we have to wait for it to be deployed?

http://graphs-new.mozilla.org/graph.html#tests=[[102,1,17]]&sel=none&displayrange=90&datatype=running
(Assignee)

Comment 16

7 years ago
I don't have an idea of the exact impact - I have a limited number of test boxes that haven't been updated in a while.  So while I can ensure that patches will go green and tests will run it isn't an exact replication of the production environment.
Flags: needs-treeclosure?
Flags: needs-treeclosure? → needs-treeclosure+
Attachment #557281 - Attachment description: update names of flash zips in buildbot-configs → [checked in] update names of flash zips in buildbot-configs
Attachment #557301 - Attachment description: download 64 bit flash for win764/fed64 only → [checked in] download 64 bit flash for win764/fed64 only
(Assignee)

Comment 17

7 years ago
Created attachment 561447 [details] [diff] [review]
remove plugins option from AddonTester branch

Tp tests are not run on the AddonTester branch and this option is not required there - it is also in the 'old' format instead of the new 32/64 bit split.
Attachment #561447 - Flags: review?(bhearsum)
(Assignee)

Comment 18

7 years ago
Created attachment 561448 [details] [diff] [review]
[checked in] remove plugins option from AddonTester/AddonbaselineTester branch
Attachment #561447 - Attachment is obsolete: true
Attachment #561447 - Flags: review?(bhearsum)
Attachment #561448 - Flags: review?(bhearsum)
Attachment #561448 - Attachment description: remove plugins option from AddonTester/AddonbaselineTester branch → [checked in] remove plugins option from AddonTester/AddonbaselineTester branch
Attachment #561448 - Flags: review?(bhearsum) → review+
successfully landed in the downtime
Flags: needs-treeclosure+
(Assignee)

Comment 20

7 years ago
Deployed.  Done here.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.