664728 - update plugins used by talos

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[alice nodelman [:alice] [:anode]]

Talos installs plugins into the default profile per-test run.  I don't believe that these have been updated in a long time.

Comment 2

[alice nodelman [:alice] [:anode]]

Pulling new copies of flash today, version 10.3.183.5.

Comment 3

[Benoit Girard (:BenWa)]

\o/!
Thanks, this is important to fix the shutdown regression and may let us land bug 673440 without regressing.

Comment 4

[alice nodelman [:alice] [:anode]]

Don't get too excited just yet - still need to do some staging before this is ready to get deployed.

Comment 5

[alice nodelman [:alice] [:anode]]

So, during testing I'm finding some exceptions that will have to be handled:

- we'll want to run 64 bit flash on 64 bit browsers, this would be on our win7-64bit, fedora-64bit and most mac installs (for this I'll use Beta 2 11.0.d1.98, which is the current 64 bit flash release)
- we'll still need to install 32 bit flash correctly on xp, fed and the 1.9.2 branch

Comment 6

[alice nodelman [:alice] [:anode]]

Attachment: [checked in] update names of flash zips in buildbot-configs

Comment 7

[alice nodelman [:alice] [:anode]]

Attachment: download 32/64 bit flash based upon os

Comment 8

[alice nodelman [:alice] [:anode]]

Patches green on staging.  New flash zips have already been posted to the build server by lsblakk.

Flash is installed and working.  Tested against nightly and 1.9.2 builds for confirmation.

Comment 9

[alice nodelman [:alice] [:anode]]

Also, I've split out:

32 bit:
- use flash version 10.3.183.5
64 bit:
- use flash version 11.0.d1.98

Comment 10

[Benoit Girard (:BenWa)]

> - we'll want to run 64 bit flash on 64 bit browsers, this would be on our
> win7-64bit, fedora-64bit and most mac installs (for this I'll use Beta 2
> 11.0.d1.98, which is the current 64 bit flash release)

I don't think we want to use 64 bit flash release on mac. Our default configuration, used by our users, is to use the 64 bit browser and run 32 bit plugins using a compatibility layer. I believe this is only the case on Mac. Flash 64-bit is still beta software so I think we rather test our default configuration.

Comment 11

[alice nodelman [:alice] [:anode]]

So, that would mean only 64 bit on fed64 and win764.  I'll try and get some new zips and patch changes pulled together.

Comment 12

[alice nodelman [:alice] [:anode]]

Attachment: [checked in] download 64 bit flash for win764/fed64 only

Comment 13

[alice nodelman [:alice] [:anode]]

Copies of flash zips have been updated on the build server by lsblakk.  32 bit flash zip now contains 10.3.183.5 for mac.

The new split is:

32 bit (fed, winxp, win7, leopard, snow leopard):
- use flash version 10.3.183.5
64 bit (fed64, win7 64):
- use flash version 11.0.d1.98

Comment 14

[alice nodelman [:alice] [:anode]]

This is now waiting on deployment, which must happen during a downtime as it will affect all tp4/tp5 results.

I've not checked in the patches as I don't want them to get accidentally picked up during a non-downtime reconfig.

Comment 15

[Benoit Girard (:BenWa)]

Do we have any measurement of the impact this will have for Talos? I'm expecting this upgrade to fix the tp5 shutdown regression. Or do we have to wait for it to be deployed?

http://graphs-new.mozilla.org/graph.html#tests=[[102,1,17]]&sel=none&displayrange=90&datatype=running

Comment 16

[alice nodelman [:alice] [:anode]]

I don't have an idea of the exact impact - I have a limited number of test boxes that haven't been updated in a while.  So while I can ensure that patches will go green and tests will run it isn't an exact replication of the production environment.

Comment 17

[alice nodelman [:alice] [:anode]]

Attachment: remove plugins option from AddonTester branch

Tp tests are not run on the AddonTester branch and this option is not required there - it is also in the 'old' format instead of the new 32/64 bit split.

Comment 18

[alice nodelman [:alice] [:anode]]

Attachment: [checked in] remove plugins option from AddonTester/AddonbaselineTester branch

Comment 19

[[e-mail] (:bhearsum)]

successfully landed in the downtime

Comment 20

[alice nodelman [:alice] [:anode]]

Deployed.  Done here.