Closed
Bug 673447
Opened 13 years ago
Closed 13 years ago
TypeError: __init__() takes exactly 3 arguments (2 given) in ChromeManifest
Categories
(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P1)
addons.mozilla.org Graveyard
Compatibility Tools
Tracking
(Not tracked)
VERIFIED
FIXED
6.1.7
People
(Reporter: kumar, Assigned: basta)
References
Details
Using this addon: https://addons.mozilla.org/firefox/downloads/latest/5180/platform:3/addon-5180-latest.xpi?src=addondetail $ ./addon-validator --determined -o json --target-appversion='{"{ec8030f7-c20a-464f-9b0e-13a3a9e97384}": "7.*"}' --for-appversions='{"{ec8030f7-c20a-464f-9b0e-13a3a9e97384}": ["7.*"]}' ~/tmp/addon-exceptions/afrikaans_language_pack-4.0-fx-mac.xpi Traceback (most recent call last): File "./addon-validator", line 6, in <module> validator.main.main() File "/Users/kumar/dev/amo-validator/validator/main.py", line 109, in main for_appversions=for_appversions) File "/Users/kumar/dev/amo-validator/validator/validate.py", line 47, in validate for_appversions=for_appversions) File "/Users/kumar/dev/amo-validator/validator/submain.py", line 54, in prepare_package for_appversions) File "/Users/kumar/dev/amo-validator/validator/submain.py", line 120, in test_package return test_inner_package(err, package, for_appversions) File "/Users/kumar/dev/amo-validator/validator/submain.py", line 279, in test_inner_package test_func(err, xpi_package) File "/Users/kumar/dev/amo-validator/validator/testcases/l10ncompleteness.py", line 217, in test_lp_xpi reference_locales = _get_locales(None, ref_xpi) File "/Users/kumar/dev/amo-validator/validator/testcases/l10ncompleteness.py", line 50, in _get_locales locales = _list_locales(err, xpi_package) File "/Users/kumar/dev/amo-validator/validator/testcases/l10ncompleteness.py", line 36, in _list_locales chrome = ChromeManifest(xpi_package.read("chrome.manifest")) TypeError: __init__() takes exactly 3 arguments (2 given) This is causing a handful of exceptions mostly in language packs. See bug 673336
Reporter | ||
Updated•13 years ago
|
Assignee: nobody → mbasta
Assignee | ||
Comment 1•13 years ago
|
||
Fixed: https://github.com/mattbasta/amo-validator/commit/18834e1e7153074579146372ed740ded949d611d
Comment 2•13 years ago
|
||
We need this pushed in prod ASAP.
Severity: normal → blocker
Priority: -- → P1
Target Milestone: --- → 6.1.7
Comment 3•13 years ago
|
||
Since we also need bug 673590 for the bump, those 2 fixes can be pushed together. It's probably best not to push them right away because the final resolution of bug 672063 is still pending some testing. I'll let you know when we can do that.
Reporter | ||
Comment 4•13 years ago
|
||
This is in Zamboni as of https://github.com/jbalogh/zamboni-lib/commit/5ce0095
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•13 years ago
|
||
Pushed: https://github.com/mozilla/amo-validator/commit/382264c47d87b0b143390ac3ba3bc91828dbea28
Comment 6•13 years ago
|
||
verified fixed at https://addons.allizom.org/z/en-us/developers/upload/eb8f5607037548aa81bf1553ecb98476
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•