Created attachment 547754 [details] [diff] [review]
Streamlining things. This border bugged me for some time now.
I pushed this to the UX branch.
Looks good, Is there a bug to remove it from the search box ?
There's nothing like this in the search box.
There's one border when there's text in the search box and when the search box hasn't the focus.
That's not on mozilla-central -- comments you have on that should go in bug 592909.
I'd argue that this change make the location bar look MORE cluttered. Now you have (in OS X at least) the star, the drop-down arrow, and the reload, sitting side-by-side much like the add-ins icons, or OS X's native widgets in the upper-right of the screen or Windows task bar icons. But then the mouse-over effect for each icon is completely different -- the star glows slightly, nothing happens to the down arrow, and the reload gets a border, a background-color, and a gradient.
The down arrow needs to go all-together: it lists the most recently entered URLs, but why should these be available? The awsomebar does more than this. Perhaps this should be an add-on?
The star should probably be on the left side, close to the URL replacing the site icon which is shown in the current tab. Then "reload" "stop" or "go" would be there by themselves, cleaner and clearer.
I agree that this isn't ideal and personally think the reload button should be moved back between back/forward and the location bar, but I have no hope to convince the UX team of this :)
To clarify, I agree that having all these things crammed into the location bar isn't ideal. However, I don't consider the separator a good tradeoff -- it feels disruptive and I think we're better off without it right now. Reducing the number of icons is something we look into independently.
(In reply to comment #8)
> To clarify, I agree that having all these things crammed into the location
> bar isn't ideal. However, I don't consider the separator a good tradeoff --
> it feels disruptive and I think we're better off without it right now.
> Reducing the number of icons is something we look into independently.
I agree the border seems like unnecessary visual noise here. Although the reason I put the border there to begin with was to try and keep the lucky charms and the refresh button from running together. Which they seem to do without a visual separator.
Some things that could improve the appearance and flow until we can look into removing/relocating some stuff:
- More subtle history dropdown icon
- More consistent spacing between icons
- Removing the hover and active button styles also
I can file followups for those.
Verified fixed with 8.0b1 eo for Linux x86_64.